This project is archived and is in readonly mode.

#5753 ✓resolved
Aditya Sanghi

fix snowman test helper to include _method only on non-GET or non-POST

Reported by Aditya Sanghi | October 3rd, 2010 @ 08:36 PM

Writing a test for a search_field related bug recently (5730), turned out to be slightly harder than usual since the expected resulted included a _method = 'get' within the snowman method.

I've included a patch to ensure that the _method only outputs for non-GET or non-POST queries. (i thought perhaps it better to check non-GET and non-POST rather than PUT or DELETE since in the future perhaps we might support other verbs (RESTfulie?) in the snowman.

I've also modified my test to actually work as a "method" get, since it was a search form.

Basically this patch fixes the test helpers to ensure "whole_form" and "snowman" can be used correctly in tests.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Referenced by

Pages