This project is archived and is in readonly mode.
date_select helper separator functionality bug
Reported by lee (at leemuro) | October 15th, 2010 @ 02:21 PM | in 3.0.2
It appears if you use the date_select helper and you make the year your last select using the :order param, then you won't get a separator before that year select. For example, I did the following in my view:
date_select("post", "written_on", :order => [:day, :month, :year], :date_separator => '/')
and I ended up with:
Notice there is no separator before the year.
It appears the code for the date helper never returns a separator for the year select. Is this intended behavior or a bug? I would have expected to see a separator.
Comments and changes to this ticket
-
Aditya Sanghi October 15th, 2010 @ 06:16 PM
- State changed from new to incomplete
- Milestone set to 3.x
- Assigned user set to José Valim
- Importance changed from to Low
Confirm that this is indeed a problem. Added failing test.
The problem is only seen when separator is used in conjunction with order option.
Still needs a patch though. upcoming.
-
Aditya Sanghi October 15th, 2010 @ 06:58 PM
- State changed from incomplete to open
- Tag changed from actionview, date_helper to actionview, date_helper, patch
..and including patch to fix the issue.
-
Aditya Sanghi October 20th, 2010 @ 09:29 AM
- Milestone changed from 3.x to 3.0.2
-
Aditya Sanghi November 1st, 2010 @ 10:37 AM
Bump for attention. Does this look fine? Changes? Please acknowledge :)
-
Aditya Sanghi November 5th, 2010 @ 07:10 AM
- State changed from open to verified
-
Santiago Pastorino November 11th, 2010 @ 03:15 AM
Please can you merge that in one patch and add the [#ticket_number state:stuff]
-
Repository November 11th, 2010 @ 02:30 PM
- State changed from verified to resolved
(from [920660b19c5419c6df1c234a84e7fec71b169544]) patching to ensure separator is printed with order [#5816 state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/920660b19c5419c6df1c234a84e7f... -
Repository November 11th, 2010 @ 02:36 PM
(from [1b66a646db9aad9e9bb18df967eb29cd1eb6453b]) patching to ensure separator is printed with order [#5816 state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/1b66a646db9aad9e9bb18df967eb2...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 5816 date_select helper separator functionality bug (from [920660b19c5419c6df1c234a84e7fec71b169544]) patchin...
- 5816 date_select helper separator functionality bug (from [1b66a646db9aad9e9bb18df967eb29cd1eb6453b]) patchin...