This project is archived and is in readonly mode.
date_select helper separator functionality bug
-
Aditya Sanghi- State changed from new to incomplete
- Milestone set to 3.x
- Assigned user set to José Valim
- Importance changed from to Low
Confirm that this is indeed a problem. Added failing test.
The problem is only seen when separator is used in conjunction with order option.
Still needs a patch though. upcoming.
-
date_helper_separator_order.diff
3.37 KB
-
Aditya Sanghi
- State changed from incomplete to open
- Tag changed from actionview, date_helper to actionview, date_helper, patch
..and including patch to fix the issue.
-
Aditya Sanghi
- Milestone changed from 3.x to 3.0.2
-
Aditya Sanghi
Bump for attention. Does this look fine? Changes? Please acknowledge :)
-
lee (at leemuro)
This looks good to me. Fixes the issue.
-
Aditya Sanghi
- State changed from open to verified
-
Santiago Pastorino
Please can you merge that in one patch and add the [#ticket_number state:stuff]
-
-
Repository
- State changed from verified to resolved
(from [920660b19c5419c6df1c234a84e7fec71b169544]) patching to ensure separator is printed with order [#5816 date_select helper separator functionality bug state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/920660b19c5419c6df1c234a84e7f... -
Repository
(from [1b66a646db9aad9e9bb18df967eb29cd1eb6453b]) patching to ensure separator is printed with order [#5816 date_select helper separator functionality bug state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/1b66a646db9aad9e9bb18df967eb2...