jquery-ujs rails.js doesn't work with jQuery 1.4.3

Seeing this as well. I'm thinking it's due to the way 1.4.3 now handles the html data attributes.

Honestly, I would increase the priority.
If you upgrade to jQuery 1.4.3 and you use :confirm on a delete action, the record will be delete no matter if you click on cancel...

Update:

In jQuery 1.4.3 "returning false" does not mean that rest of live bindings will not be called.

http://jsbin.com/ehagi4/2/edit

http://jsbin.com/ehagi4/3/edit

I am trying to get a confirmation from jQuery team if that is intentional ( most likely it is) or if it is a bug.

In the meantime I would suggest not to upgrade to jQuery 1.4.3 least of which is because of rails.js. This feature of going through all live bindings potentially can break a lot of things in your app. :-)

We've temporarily resolved this issue by replacing the live call with a delegate:

// $('a[data-confirm],input[data-confirm]').live('click', function () { ... $('body').delegate('a[data-confirm],input[data-confirm]','click', function(e) { ...

Let's try that again:

// $('a[data-confirm],input[data-confirm]').live('click', function () { ... $('body').delegate('a[data-confirm],input[data-confirm]','click', function(e) { ...

I hate markdown.

// $('a[data-confirm],input[data-confirm]').live('click', function () { ...
$('body').delegate('a[data-confirm],input[data-confirm]','click', function(e) { ...

@Yuval That works.

I am still awaiting to hear from jQuery core team regarding official statement. As per http://jsbin.com/ehagi4/4/edit looks like using delegate works as jQuery 1.4.2 works with live with respect to not continuting with the call chain once 'return false' has been invoked.

delegate was introduced in jQuery 1.4.2. If rails.js starts using that then people will not be able to use jQuery 1.4.1.

I will wait for the official statement from jQuery team and then we will try to find a solution.

I use JQuery 1.4.3 and Jquery-ujs today and here that's ok.
Maybe issue its fixed.

I'm still seeing this problem with 3.03, jquery 1.4.4, and the latest rails.js from https://github.com/rails/jquery-ujs/blob/master/src/rails.js.

http://bugs.jquery.com/ticket/7217 seems to be the relevant jquery bug but is fixed in 1.4.4.

http://bugs.jquery.com/ticket/7520 also filed and still open

That is why in the current version of rail.js confirmation is bound to body and not to document. https://github.com/rails/jquery-ujs/blob/master/src/rails.js#L80

Can you describe what is the issue you are running into with rails.js ?

I have a simple Delete link as follows
<%= link_to 'Destroy', @report, :confirm => 'Are you sure?', :method => :delete %>

When I click on it, it gives me the confirmation pop-up and if I click "Cancel", it repeats the pop-up one more times and then still deletes the record and tries to show the deleted record (does a GET "report/:id" request)

Just now I tested with

rails edge
jQuery 1.4.4
railsj.js current version

when I click on cacel nothing happens. There is no repetition.

I tested with FF, safari and chrome.

Ok, I tried again using a skeletal app and everything works fine. I isolated the problem to trying to use ujs with the jquery-colorbox plugin in my original app.

Sorry for the confusion