Whoops, I should have put [PATCH] in the subject and I didn't.

Good idea. I have made that change. The negative format is now "-" + :format by default if a format is specified. Of course, if they specify :negative_format, that format is used.

For example:
number_to_currency(-1.23) => "-$1.23"
number_to_currency(-1.23, {:format => "%n %u"}) => "-1.23 $"
number_to_currency(-1.23, {:format => "%n %u", :negative_format => "(%n %u)"}) => "(1.23 $)"

The new patch is attached.

I have a client in Brazil that complaint exactly about the negative format used by Rails, so +1!

Andrew, I'll definitely squash the patch into one commit. I realized I had done that after I uploaded it.

I'm not sure what you mean by your other suggestion, though. I agree that the negative_format should also be looked up in the locale. However, if a user specifically passes in a format, I think the negative_format should still be overridden to be the "-" + the format specified regardless of the locale.

Can you explain what you mean?

Absolutely the passed option should override the locale format - I just meant that you could specify it in your locale file to override it throughout the application. Could you also do one patch for master and another for 3-0-stable please.

OK, thanks for clarifying that for me. It makes sense now.

I have squashed the patch into one commit and I attached a patch for master and another for 3-0-stable!

Don, can you also add some tests to number_helper_i18n_test.rb to test the locale lookup please, so that we don't get any regressions - similar to the tests already there but with negative numbers.

Good idea. I have included new patches with i18n tests!

(from [c4d977fbbc31b0a6c7557846f9fe01e688a6f845]) Added :negative_format option to number_to_currency function [#5894 number_to_currency doesn't format negative numbers correctly state:resolved]

Signed-off-by: Andrew White andyw@pixeltrix.co.uk
http://github.com/rails/rails/commit/c4d977fbbc31b0a6c7557846f9fe01...

Automatic cleanup of spam.

giao xu quy de
nha tho quy de
nha tho nam dinh

very nice pictures is also very lively and attractive you look .every one who wanted to congratulate you You look super. Ankara nakliyat A wonderful picture,nakliyat ankara and always such a special and very attractive as well stay beautiful ok Ankara evden eve nakliyat Ankara nakliye

I Agree "However, if a user specifically passes in a format, I think the negative_format should still be overridden to be the "-" + the format specified regardless of the locale."

by antalya hotels

I disagree that Krugman is any more reliable a source than Romney on the stimulus. They are equally hostage to their respective partisan agendas, and have an equal disrespect for the actual situation, not that either of them bother to investigate it. hosting

It's pretty interesting and informative topic. This is exactly what I was looking for. I shared this post to my Facebook account. Keep up the good work!