Rails Ruby on Rails → 3.0.2

Comments and changes to this ticket

• You flagged this item as spam.
  

  Clemens Kofler July 11th, 2008 @ 10:57 AM

  • Tag changed from “2.1, generators, patch” to “2.1, generators, patch, railties”

  All tests pass. Although I think the scaffold shouldn't be used anyways (or, rather, that you usually throw away the views), it kinda makes sense.

  • 1/2 ;-)
• 

  Pratik July 17th, 2008 @ 01:25 AM

  • State changed from “new” to “wontfix”

  I don't really see much value in this patch. Scaffolding is really meant as a learning tool. Apart from that, as you've moved some stuff to styles.css, it'll make things ugly when people upgrades Rails and when they already have styles.css in their public directory.

• You flagged this item as spam.
  

  Andrew Chalkley July 17th, 2008 @ 01:55 AM

  Hi Pratik,

  The idea of making the changes was to help the rails developer starting off on the right foot. Unobtrusive CSS, well formatted HTML etc, etc.

  Having the notice auto generate a paragraph if present is a good for learning, surly?

  styles.css doesn't get "generated" in their public directory but scaffold.css doesn't it?

  When people upgrade Rails adding a bit of CSS wouldn't be that big of an issue since environments/initialisers have been known to change between updates. I'd imagine mature rails projects will have it's own CSS for notices anyway. But since I would imaging scaffolding would be used primarily at the beginning of a project anyway this wouldn't be a big problem.

  Or am I missing something :S ?

• You flagged this item as spam.
  

  dan (at danwebb) July 28th, 2009 @ 11:17 AM

  I want to support this one. Yes, it is a learning tool and not to be used in production but that why it's a even more important to make sure its not full of nasty markup and inline CSS. Rails is promoting best practices right? I don't think the style.css/upgrade issue is anywhere near enough of a problem to can this and the markup stuff is very worth putting in.

• You flagged this item as spam.
  

  Glenn Gillen July 28th, 2009 @ 11:30 AM

  For what it's worth, I'd give this a +1.

  "I don't really see much value in this patch."

  I don't see much justification for knowingly generating bad markup.

• 

  Pratik July 30th, 2009 @ 05:07 PM

  • State changed from “wontfix” to “new”

  I'm pretty sure there was a long discussion in the ML about rejecting this change. But as I cannot find it, I'm reopening the ticket.

  Thanks.

• 

  Pratik July 30th, 2009 @ 05:08 PM

  Also, I think the following :

  <% if flash[:notice].present? %>
    <p style="color: green"><%%= flash[:notice] %></p>
  <% end %>
  

  is better than :

  <%%= content_tag(:p, flash[:notice],:id => "notice") unless flash[:notice].blank? %>
  

• 

  José Valim August 10th, 2009 @ 10:48 AM

  • Assigned user set to “José Valim”
  • Milestone cleared.

• You flagged this item as spam.
  

  Andrew Chalkley August 10th, 2009 @ 01:30 PM

  • Tag changed from “2.1, generators, patch, railties” to “3.0, generators, patch, railties”

  Well, it'd be nice to have the notice in the id attribute and not have inline styling...

  
<% if flash[:notice].present? %>


  <%%= flash[:notice] %>

  <% end %>
  
• 

  Repository August 30th, 2009 @ 08:06 PM

  (from [5096ba961c49e5b419c3400acd7c87373a36d6d4]) Remove inline css. [#593 status:resolved] http://github.com/rails/rails/commit/5096ba961c49e5b419c3400acd7c87...

• 

  José Valim September 1st, 2009 @ 12:16 PM

  • State changed from “new” to “resolved”
• 

  Jeremy Kemper October 15th, 2010 @ 11:01 PM

  • Milestone set to “3.0.2”
  • Importance changed from “” to “”

  [bulk edit]