This project is archived and is in readonly mode.
Print controller module into request log
Reported by Dmitry Sokurenko | July 10th, 2008 @ 09:38 PM | in 2.x
Currently ActionController request log contains only controller class name, without module, like
Processing UsersController#index ...
When you put half of you controllers in modules, like UsersController and Admin::UsersController, then the absence of module in the log becames a problem. Mostly for log analysis tools, and for situations when you encounter some routing bugs and can't undersand what controller processed the request.
So I think it would be better to have such output:
Processing Admin::UsersController#index ...
So there is a patch to fix it.
Comments and changes to this ticket
-
Clemens Kofler July 11th, 2008 @ 10:14 AM
- Tag changed from “actionpack, controller, enhancement, patch” to “actionpack, controller, enhancement, patch, tested”
+1 from me. It passes the tests and makes total sense.
-
Clemens Kofler July 11th, 2008 @ 10:47 AM
Little note: A single test fails ->
1) Failure:
test_action_cache_conditional_options(ActionCacheTest)
[./test/controller/caching_test.rb:290:in `test_action_cache_conditional_options'
./test/../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:91:in `__send__'
./test/../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:91:in `run']:
is not true.
But this also fails w/o the patch so I don't think it's related.
-
-
Repository July 17th, 2008 @ 01:34 AM
- State changed from “new” to “resolved”
(from [f7fdbae770275ccbc277c42287b9783cb00fa9fa]) Use fully-qualified controller name when logging. [#600 state:resolved]
Signed-off-by: Pratik Naik
-
Repository August 25th, 2008 @ 09:27 AM
(from [6fbd6c0a009e4848b9cd2e0a055b8ecdb867049f]) Use fully-qualified controller name when logging. [#600 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Clemens Kofler
Dmitry Sokurenko
Pratik
Ripta Pasay
Attachments
Referenced by
-
600
Print controller module into request log
(from [6fbd6c0a009e4848b9cd2e0a055b8ecdb867049f]) Use ful...