This project is archived and is in readonly mode.
Added disable_authenticity_token option to form helper
I've added disable_authenticity_token option to the form helper.
So now we can generate forms without authenticity_token tag.
It is useful when we generate forms for some external resources
like payments and billings where names of fields are often
restricted so forms with authenticity_token are not valid.
Now we can write:
form_for(@survey, :disable_authenticity_token => true)
or:
form_tag('/', :disable_authenticity_token => true)
-
Yaroslav Markin- Assigned user set to José Valim
This is basically really useful when you need to send data to a 3td party service (payment gateway, in my case) without any Rails tokens.
-
Santiago Pastorino- State changed from new to open
- Milestone set to 3.1
- Assigned user changed from José Valim to Santiago Pastorino
- Importance changed from to Low
Looks good can you provide docs for that? would be nice to add API docs at least
-
Xavier NoriaWould you please add some RDoc documenting this option and its rationale/real use case. Also please the guide that covers forms? All in a single (complete) patch.
-
Lachlan Sylvester
Similar functionality has been added in https://rails.lighthouseapp.com/projects/8994/tickets/2988-authenti.... I am not sure that this is still needed.
-
Dan PickettAgreed with Lachlan - this appears to be duplicated functionality that has already been committed in #2988. This ticket should be closed.
-
Santiago Pastorino
yeah true, but ... seems that this was not done for form_for.
Can you guys confirm this? if it was not done for form_for can you provide a patch for it using the same approach?.
Thanks. -
-
Santiago Pastorino
2kan right, but we don't have tests and docs for form_for though.
-
2kan
Added test for for_for and new authenticity_token option. Added docs. Added section about it to form helpers guide. All in one single patch.
-
6228-added-test-and-docs.diff
6.42 KB
-
-
Repository
- State changed from open to committed
(from [b9309b47cda12db34ac3427fbafff2dca0314ed7]) Added tests for form_for and an authenticity_token option. Added docs for for_for and authenticity_token option. Added section to form helpers guide about forms for external resources and new authenticity_token option for form_tag and form_for helpers.
[#6228 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/b9309b47cda12db34ac3427fbafff... -
Dan Pickett
I dig the change, but I think putting the authenticity_token arg in the html option hash is unintuitive. I've attached a patch that puts the function in parity with the remote option.
-
auth_token_remote_parity.diff
3.17 KB
-
-
-
Santiago Pastorino
Yeah agree pushing the change
-
Repository
- State changed from open to committed
(from [3026843dc1ff42a632ebe989e1f6dfadb0cd10a5]) put authenticity_token option in parity w/ remote
[#6228 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/3026843dc1ff42a632ebe989e1f6d... -
2kan
- State changed from committed to open
[state:open]
Updated form helpers guide for new place of authenticity_token option in for_for helper.
-