This project is archived and is in readonly mode.
[Patched] ActiveModel::Serialization Documentation Example Fix
-
Nathaniel Bibler
Attached is a patch to remove the memoization from the example, as well as correctly return the attribute value in the generated hash.
-
Nathaniel Bibler
- Title changed from ActiveModel::Serialization Documentation Example Fix to [Patched] ActiveModel::Serialization Documentation Example Fix
- Tag changed from activemodel, documentation, serialization to activemodel, documentation, patch, serialization
-
Nathaniel Bibler
Fixed the second example, as well.
-
Nathaniel Bibler
- Tag changed from activemodel, documentation, patch, serialization to activemodel, doc, documentation, patch, serialization
-
Tyler Hunt
+1, although ideally the serializers would actually use the values from the attributes hash, rather than just the taking the keys and using #send to get the values.
-
Santiago Pastorino
- State changed from new to resolved
- Importance changed from to Low
Hey Nathaniel, do you mind to go ahead and push that to http://github.com/lifo/docrails ?
Thanks. -
Repository
- State changed from resolved to committed
(from [285fdbae2bafd5de415a685b57af36254197348c]) Fixed broken, memoized attributes method example
[#6245 [Patched] ActiveModel::Serialization Documentation Example Fix state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/285fdbae2bafd5de415a685b57af3... -
Nathaniel Bibler
Awesome, glad you liked the patch. Thanks for the commit, Santiago. :)
