This project is archived and is in readonly mode.

#626 ✓stale
Mark Cornick

Scaffolded functional tests should test for failed create/update

Reported by Mark Cornick | July 15th, 2008 @ 07:28 PM | in 2.x

Currently, the functional tests generated by the scaffold generator do not test the parts of the create and update actions which handle failed creates/updates. The tests should be updated to cover the entire create and update actions.

This is difficult to accomplish in a way that is both automatic and elegant. We could create new tests passing invalid parameters to the create/update actions, but we do not define any validations at the time that the generator is run, and so we have no way of knowing what constitutes invalid parameters. We could mock the .save and .update_attributes methods to fail, but we cannot depend on the developer having an appropriate mocking library installed. We could dike out the save/update methods with sneaky uses of the private define_method call, but that approach is ugly.

The attached patch simply defines two new tests, one for create and one for update, with the same parameters as the original tests, but expecting the operation to fail instead of to succeed. It also includes FIXME notes stating that these tests will fail until validations are added to the model and the tests are updated with parameters that fail those validations.

I expect this change to be controversial, in that scaffold-generated tests will now fail out of the box. My rationale is that if we consider scaffolding to be an educational tool (see, doing it this way will help the developer learn to write tests; besides, the sort of people who are inclined to not run tests won't notice the failure anyway (and those who are so inclined will either fix the tests to pass, or remove them entirely.)

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket