This project is archived and is in readonly mode.
[PATCH] Prevent ActiveRecord SessionStore from saving non-dirty sessions.
-
Bart ten Brinke
- This saves a truckload of db traffic.
-
Willem van Bergen
I k ow I am nitpicking, but please change
def data_changed? return false if original_data == data endto
def data_changed? original_data != data endOther than that: +1
-
Bart ten Brinke
- No changes were found…
-
Bart ten Brinke
Included Willem's suggestion :)
-
Bart ten Brinke
- Tag changed from active record, locking, sessions, session_store.rb to active record, locking, sessions, session_store.rb, verified
-
rails
- Tag changed from active record, locking, sessions, session_store.rb, verified to active record, locking, sessions, session_storerb, verified
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails
- State changed from open to stale
