#6329 [PATCH] Prevent ActiveRecord SessionStore from saving non-dirty sessions. - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6329 ✓stale

[PATCH] Prevent ActiveRecord SessionStore from saving non-dirty sessions.

Reported by Matthijs Langenberg | January 24th, 2011 @ 10:44 AM

By default, Rails saves the session after each request to the database.
When executing multiple XHR requests in parallel, this may result in a database lock. Because all XHR requests are trying to UPDATE the same session record (with the same data).
This patch fixes this, by comparing the unmarshaled new and original data hashes. And only saving them if they differ.

Comments and changes to this ticket

You flagged this item as spam.
Matthijs Langenberg January 24th, 2011 @ 10:46 AM
https://gist.github.com/793064
You flagged this item as spam.
Matthijs Langenberg January 24th, 2011 @ 10:47 AM
- no changes were found...
- ar_session_store_non_dirty.diff 1.4 KB
You flagged this item as spam.
Bart ten Brinke January 24th, 2011 @ 10:50 AM
1. This saves a truckload of db traffic.
You flagged this item as spam.
Bart ten Brinke January 24th, 2011 @ 10:50 AM
+1
You flagged this item as spam.
Willem van Bergen January 24th, 2011 @ 01:16 PM
I k ow I am nitpicking, but please change
```
  def data_changed?
    return false if original_data == data
  end
```
to
```
  def data_changed?
    original_data != data
  end
```
Other than that: +1
You flagged this item as spam.
Bart ten Brinke January 24th, 2011 @ 02:18 PM
- no changes were found...
You flagged this item as spam.
Bart ten Brinke January 24th, 2011 @ 02:18 PM
Included Willem's suggestion :)
- ar_session_store_non_dirty2.diff 1.4 KB
You flagged this item as spam.
Olaf van Zandwijk January 24th, 2011 @ 02:21 PM
+1
You flagged this item as spam.
Bart ten Brinke January 24th, 2011 @ 02:31 PM
- Tag changed from “active record, locking, sessions, session_store.rb” to “active record, locking, sessions, session_store.rb, verified”
You flagged this item as spam.
Tobias Schmidt January 28th, 2011 @ 03:30 AM
+1
rails April 29th, 2011 @ 01:00 AM
- Tag changed from “active record, locking, sessions, session_store.rb, verified” to “active record, locking, sessions, session_storerb, verified”
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
rails April 29th, 2011 @ 01:00 AM
- State changed from “open” to “stale”