Willem van Bergen's profile

Willem van Bergen commented at 1:16 PM

I k ow I am nitpicking, but please change

  def data_changed?
    return false if original_data == data
  end

  def data_changed?
    original_data != dat...

Willem van Bergen commented at 6:24 AM
The new generator uses the directory name to create the session key prefix, instead of the application name. So, when I fork "MyApp" in a directory called "thei...

Willem van Bergen created the ticket at 10:14 AM
When running rake rails:update using Rails 3.0.0.rc2, it will not generate the correct session key. It generates:
```
MyApp::Application.config.session_store :cook...
```

Willem van Bergen commented at 1:14 PM
I see I ran the benchmark with my patch applied on my less powerful notebook (see the difference in REXML performance). So the performance is even more impressi...
Willem van Bergen commented at 11:35 AM
Note that I also wrote a SAX-based backend using Nokogiri, which is even faster. See my other ticket at https://rails.lighthouseapp.com/projects/8994/tickets/36...
- Tag changed from activesupport, backend, libxml, patch, xmlmini to activesupport, backend, libxml, nokogiri, patch, xmlmini
- Title changed from [PATCH] XmlMini - Fixed LibXML backend issues to [PATCH] XmlMini - Fixed bugs and improved speed of LibXML and Nokogiri backend
by Willem van Bergen at 11:28 AM
The last patch was for the master branch. I backported the changes to the 2-3-stable branch, basically by copy pasting the relevant bits of the code and tests. ...

- Tag changed from activesupport, backend, nokogiri, patch, sax, xmlmini to activesupport, backend, libxml, nokogiri, patch, sax, xmlmini
- Title changed from SAX/Nokogiri backend for XmlMini to [PATCH] SAX-based backend for XmlMini, using Nokogiri and/or LibXML
by Willem van Bergen at 1:04 PM
Willem van Bergen commented at 1:03 PM
And a backported version for Rails 2.3.
Willem van Bergen commented at 12:48 PM
I attached a file which implements two SAX-based parsers for XmlMini, using both Nokogiri and LibXML. Currently, this patch is only for the master branch. I wil...
Willem van Bergen commented at 11:39 AM
I have also rewrote the current LibXML and Nokogiri backends to fix bugs and improve speeds, for both Rails 3 and Rails 2.3. See the ticket for patches at https...