Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Patch to remove trailing spaces from truncate result.

#6357

Currently it's possible to end up with a space in the truncated results. That is:

"one two three".truncate(7) => "one ..."

The attached patch (and tests) change the result to remove that trailing space so that the result is "one...".

This changes the default behavior so may not be desirable, but it seems reasonable. If not, I could modify truncate() to accept a "strip" option which would apply the new behavior otherwise leave it as is. Thoughts?

Reported by Philip Hallstrom · February 1st, 2011 @ 07:05 PM

State: open
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. rails
    rails
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    May 2nd, 2011 @ 01:00 AM

  2. rails
    rails
    • State changed from open to stale

    May 2nd, 2011 @ 01:00 AM

  3. Philip Hallstrom
    Philip Hallstrom
    • State changed from stale to open

    This issue still applies to the 3-0 stable branch and is still applicable. Previous patch/tests still apply and pass.

    [state:open]

    May 2nd, 2011 @ 05:30 PM