Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Philip Hallstrom

Philip Hallstrom

Not a member

Philip Hallstrom's latest activity

Monday, May 02 2011
6357 Patch to remove trailing spaces from truncate result. was updated in Ruby on Rails
  • Philip Hallstrom
    • State changed from stale to open
    by Philip Hallstrom at 5:30 PM

    This issue still applies to the 3-0 stable branch and is still applicable. Previous patch/tests still apply and pass.

    [state:open]
Tuesday, February 01 2011
6357 Patch to remove trailing spaces from truncate result. was created in Ruby on Rails
  • Philip Hallstrom
    Philip Hallstrom created the ticket at 7:05 PM

    Currently it's possible to end up with a space in the truncated results. That is:

    "one two three".truncate(7) => "one ..."

    The attached patch (and tests) chan...
Thursday, March 04 2010
4101 ActiveRecord::ConnectionAdapters::Table#index does not generat indexes was updated in Ruby on Rails
  • Philip Hallstrom
    Philip Hallstrom commented at 4:35 PM

    The following applies to Rails 2.3.5....

    This got me interested so I started to write up a patch and when
    digging around in the source some more noticed that th...
Tuesday, October 06 2009
2044 Patch to add html options to the div that wraps the authenticity_token input ... was updated in Ruby on Rails
  • Philip Hallstrom
    Philip Hallstrom commented at 12:32 AM

    We need to be able to target the DIV though, not the hidden input within it.
Tuesday, April 21 2009
2044 Patch to add html options to the div that wraps the authenticity_token input ... was updated in Ruby on Rails
  • Philip Hallstrom
    Philip Hallstrom commented at 10:06 PM

    This patch works on the following:

    Rails version 2.3.2 Edge Rails revision 165d9f13ce4212468b5c2399e0560f23444d9590
  • Philip Hallstrom
    • Tag changed from form_for, form_tag, form_tag_helper, patch to authenticity_token, form_for, form_tag, form_tag_helper, patch
    by Philip Hallstrom at 9:19 PM

    I just ran into this myself. In looking into it I began to wonder why the hidden field is wrapped in a tag at all? My understanding is that hidden fields are in...
Monday, February 02 2009
1099 Patch to support PostgreSQL functional indexes. was updated in Ruby on Rails
  • Philip Hallstrom
    Philip Hallstrom commented at 10:41 PM

    I don't want to argue too much, but I'm not sure I understand why this wouldn't be a useful addition? Following Steve's logic above, couldn't one say that we do...
Tuesday, December 02 2008
1115 Path to extend named routes support for an object's to_params() method was updated in Ruby on Rails
  • Philip Hallstrom
    Philip Hallstrom commented at 7:08 PM

    I agree about nested routes. I mentioned earlier that maybe the best thing to do is not call to_params() for nested routes since that doesn't make much sense in...
Saturday, November 22 2008
1115 Path to extend named routes support for an object's to_params() method was updated in Ruby on Rails
  • Philip Hallstrom
    Philip Hallstrom commented at 4:54 AM

    Michael - Now that 2.2 is out, is it a good time to take another look at this patch?
Friday, October 24 2008
1100 JSON decoding of \u escape sequences was updated in Ruby on Rails
  • Philip Hallstrom
    Philip Hallstrom commented at 12:23 AM

    Another patch. I was encountering situations where $1 would be valid (ie. "u003c") before the $1.start_with("u") and nil immediately after.

    This patch fixes tha...