Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Removing the automatic generation of ids on submit helper

#6369

f.submit was generating

<input type="submit" value="Create Post" name="commit" id="post_submit">

Right now it's generating

<input name="commit" type="submit" value="Create Post">

Reported by Franco Andrés · February 3rd, 2011 @ 08:28 PM

State: committed
Milestone: 3.1
Assigned to: Santiago Pastorino Santiago Pastorino
Importance: Low

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Milestone set to 3.1
    • Importance changed from to Low

    Thanks Franco we need to provide a test case for this patch

    February 3rd, 2011 @ 08:31 PM

  2. Franco Andrés
    Franco Andrés

    Sorry Santiago, here is the version with the right tests

    February 3rd, 2011 @ 10:15 PM

  3. Repository
    Repository
    • State changed from open to committed

    (from [d3cfee118245a8806436bbf904bbad36dd810012]) removing generation of id in submit helper

    [#6369 state:committed]

    Signed-off-by: Santiago Pastorino santiago@wyeworks.com
    https://github.com/rails/rails/commit/d3cfee118245a8806436bbf904bba...

    February 3rd, 2011 @ 10:25 PM