This project is archived and is in readonly mode.
Thor LoadError message should not output --dev twice
Reported by Jeff Kreeftmeijer | February 14th, 2011 @ 06:51 PM | in 3.x
When running the app generator without Thor available, it prints
out an error message telling you you should have Thor and you
should append --dev to the command:
If you ran this command from a git checkout of Rails, please make sure thor is installed,
and run this command as `ruby source/bin/rails ticket_6427 --dev`
If you're already appending --dev, it'll tell you
to to run the command with --dev --dev:
If you ran this command from a git checkout of Rails, please make sure thor is installed,
and run this command as `ruby source/bin/rails ticket_6427 --dev --dev`
This was because the error message simply appended "--dev" to anything. I've attached a patch that only adds it when you're not already doing it.
Comments and changes to this ticket
-
Jeff Kreeftmeijer February 16th, 2011 @ 09:56 AM
- Assigned user set to “Jeff Kreeftmeijer”
I'll dive in once more and add tests for the Thor LoadError stuff. Hang on. :)
-
Jeff Kreeftmeijer February 27th, 2011 @ 06:55 PM
- State changed from “new” to “open”
- Assigned user changed from “Jeff Kreeftmeijer” to “Santiago Pastorino”
After discussing with José, it turned out testing this would be difficult and result in a brittle test:
(07:44:10 PM) José Valim: there is no need to test it (07:44:12 PM) José Valim: it would be hard (07:44:15 PM) José Valim: mangling the load path (07:44:23 PM) Jeff Kreeftmeijer: probably. :) (07:44:24 PM) José Valim: it would be brittleSantiago, can you apply this one? :)
-
Repository February 27th, 2011 @ 08:54 PM
- State changed from “open” to “resolved”
(from [86ad8a6c877636b4df7966233dff7fea377b0790]) Make sure the Thor generator LoadError does not output --dev twice [#6431 state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/86ad8a6c877636b4df7966233dff7...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeff Kreeftmeijer
Jeremy Kemper
Manfred Stienstra
Piotr Sarnacki
Attachments
Tags
Referenced by
-
6431
Thor LoadError message should not output --dev twice
(from [86ad8a6c877636b4df7966233dff7fea377b0790])
Make su...