Rails Ruby on Rails → 3.x

Comments and changes to this ticket

• 

  Andrew White March 5th, 2011 @ 06:55 PM

  • State changed from “new” to “open”
  • Milestone set to “3.x”
  • Assigned user set to “Andrew White”
  • Importance changed from “” to “Low”

  It needs a require added for extract_options! from ActiveSupport and some tests, then I can push it.

• You flagged this item as spam.
  

  Diego Carrion March 6th, 2011 @ 03:53 AM

  Hi, attached is the failing test. The patch from wildchild make it pass.

  • 0001-added-failing-test-for-fie.patch 1.5 KB

• You flagged this item as spam.
  

  wildchild March 6th, 2011 @ 04:05 AM

  Patch updated to require core_ext/array/extract_options.

  • 0001-allow-model-to-be-inherite.patch 1.3 KB
• 

  Repository March 6th, 2011 @ 05:51 AM

  • State changed from “open” to “resolved”

  (from [0509bf35f1987c1e0b9c3dd1389778f8426180f7]) Allow model to be inherited from Hash [#6487 state:resolved]

  Signed-off-by: Andrew White andyw@pixeltrix.co.uk
  https://github.com/rails/rails/commit/0509bf35f1987c1e0b9c3dd138977...

• 

  Repository March 7th, 2011 @ 04:51 PM

  (from [9cee693213e0205cb5992728bb516215e34cb79f]) Merge branch 'master' of github.com:rails/rails

  • 'master' of github.com:rails/rails: (44 commits) Fixed indentation in actionmailer base_test [#6538 state:committed] remove unused assigned variable removes merge conflicts removes Examples headers introduced in 9b96de6 Revert "Fixed identation in actionmailer base_test" Report the correct value of nil.id in the exception message as different ruby implementations may have different values, for example Rubinius returns 53 for nil.id. Improve testing of cookies in functional tests: - cookies can be set using string or symbol keys - cookies are preserved across calls to get, post, etc. - cookie names and values are escaped - cookies can be cleared using @request.cookies.clear more style changes Some style changes style changes Revert "style changes" Raise ArgumentError if route name is invalid [#6517 state:resolved] style changes Allow model to be inherited from Hash [#6487 state:resolved] styles applied for usage added failing test for fields_for with a record object that inherits from Hash Fixed identation in actionmailer base_test wrong SQL statement commas to set off expressions that interrupt sentence flow typo changes ... https://github.com/rails/rails/commit/9cee693213e0205cb5992728bb516...