#6575 helper :all from ActionMailer - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6575 open

helper :all from ActionMailer

Reported by Marc-André Lafortune | March 14th, 2011 @ 05:12 PM

The documentation for AbstractController::Helpers#helper states that :all is a special parameter.

Indeed, from a ActionController::Base, helper :all will use all the helper files. It even does that by default in Rails 3.

On the other hand, this doesn't work from ActionMailer::Base and we get:

Missing helper file helpers/all_helper.rb

Note that ActionMailer::Base < AbstractController::Helpers is true.

1) It would be nice if helper :all could work for ActionMailer::Base also.

2) If it did, maybe ActionMailer::Base should call it by default, as ActionController does

3) If it wont, and :all can not handled by all descendants of AbstractController::Helpers, then the doc should be updated to reflect this.

Thanks

You flagged this item as spam.
ifesdjeen March 19th, 2011 @ 12:04 PM
:all is handled by overwritten helper (actionpack/lib/action_controller/metal/helpers.rb), which overwrites modules_for_helpers to
```
    def modules_for_helpers(args)
       args += all_application_helpers if args.delete(:all)
       super(args)
    end
```
What most likely happened, that method doesn't get loaded.
If someone from Rails team could explain a bit of background behind that situation, I could provide a patch.
Thanks

Edited by Rohit Arondekar for formatting.
You flagged this item as spam.
ifesdjeen March 19th, 2011 @ 12:05 PM
For some reason my code got all messy, please see it in that gist: https://gist.github.com/877432
Neeraj Singh April 9th, 2011 @ 05:51 PM
- State changed from “new” to “open”
- Assigned user set to “José Valim”
- Importance changed from “” to “Low”
Fix is here. Please see last two commits.

https://github.com/neerajdotname/rails/commits/fix_for_6575