Marc-André Lafortune

Got bitten by this. A solution for this problem would be nice.

Here is my patch.

{Date}Time#in_time_zone, Time.use_zone and Time.zone= now raise an ArgumentError on invalid timezone arguments.

Note that I changed test_time_...

Thanks for looking it up.

For the record, EST5EDT is not quite "EDT". It is the same as "Eastern Time (US & Canada)", i.e. EST (UTC-5) in the 'winter', and 'EDT...

Sure, will do.

The documentation for AbstractController::Helpers#helper states that :all is a special parameter.

Indeed, from a ActionController::Base, helper :all will use al...

While the time zone "EST" is recognized, "EDT" isn't.

Time.now.zone # => "EST" last week, "EDT" this week.
Time.now.in_time_zone("EST").to_s # => ".... -0500"
...

Currently, the following doesn't raise any error:

t = Time.now.in_time_zone("There is no such timezone"); t.utc

Many other methods of TimeWithZone will raise ...

Thanks for testing on your side.

Yes, it could be worthwhile to add a test as you suggest.

Floats and Integers are quite different: there is no bijection between them and they don't respond to the same methods (e.g. you can't do 10.0.times{}).

Note th...