This project is archived and is in readonly mode.
submit_tag :confirm bug
#660
When doing any of the following:
submit_tag "Save", :onclick => "alert('x');", :confirmation => "Sure?"
submit_tag "Save", :disable_with => "Saving...", :confirmation => "Sure?"
the confirmation isn't executed. This patch fixes that bug.
-
submit_tag.diff
2.5 KB
-
Clemens KoflerYou should use :confirm and not :confirmation, otherwise you might confuse people (you confused me ;-)).
As for the patch, this looks like a good idea to me. Is the "return true" really necessary?
-
Lawrence PitAh yeah, sorry, the example in this ticket should indeed use :confirm. The patch is correct though. I like the return true to be explicit.
-
Lawrence Pit
- Title changed from submit_tag :confirmation bug to submit_tag :confirm bug
-
-
Pratik- Assigned user set to josh
-
Repository- State changed from open to resolved
(from [77f7d98e38dddf72890c80b4e4b2e088bb76d111]) submit_tag with confirmation and disable_with [#660 submit_tag :confirm bug state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...