This project is archived and is in readonly mode.
activesupport's to_xml shouldn't modify options hash
-
Alex MacCaw
+1
I've been burned by that one before.
-
Clemens Kofler
Good one. Not duping the options hash before using it seems to be a problem that's all across Rails.
+1
-
Chris Kampmeier
Yup, this is still a problem, I've been bitten by it a couple times.
+1 for the patch, except that the test for
Hash#to_xmlwas actually testingArray#to_xml. I fixed that, and rebased the patch against master, since it no longer applied. Here's a new one. -
CancelProfileIsBroken
- Tag changed from activesupport, core_ext, edge, patch, to_xml to activesupport, bugmash, core_ext, edge, patch, to_xml
-
Dana Jones
- Assigned user set to Pratik
+1 - Problem exists on both 2-3-stable and 3-0-pre. Neither of the preceding patches would apply cleanly, so I created new patches for both versions.
-
Dana Jones
This is the patch for Rails 3.0
-
CancelProfileIsBroken
- State changed from stale to open
-
Rizwan Reza
verified
+1 Both patches work perfectly. All tests pass.
-
Repository
- State changed from open to resolved
(from [c9d4bcf16337241cc270eddb402b17cc094c609e]) Fix that Hash#to_xml and Array#to_xml shouldn't modify their options hashes [#672 state:resolved] [David Burger, Dana Jones]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/c9d4bcf16337241cc270eddb402b17... -
Repository
(from [1382f4de1f9b0e443e7884bd4da53c20f0754568]) Fix that Hash#to_xml and Array#to_xml shouldn't modify their options hashes [#672 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/1382f4de1f9b0e443e7884bd4da53c... -
CancelProfileIsBroken
- Assigned user cleared.
- Tag changed from activesupport, bugmash, core_ext, edge, patch, to_xml to activesupport, core_ext, edge, patch, to_xml
- Milestone cleared.
