Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Deprecating ActiveRecord::Base#attributes=

#724

This is an extremely ugly method that is not ruby like enough and its been around since the beginning.

We discussed this in #ruby-contrib and everyone agreed. So, I branched and fixed it.

The new method that merges in attributes is ActiveRecord::Base#merge_attributes instead of ActiveRecord::Base#attributes= which is misleading because it looks like assignment.

I have added a deprecation warning to the use of ActiveRecord::Base#attributes=

There is a pull request on GitHub for this patch.

Reported by Hampton Catlin · July 30th, 2008 @ 12:18 AM

State: wontfix
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Rick
    Rick
    • State changed from new to open

    Hey, we upload patches to Lighthouse instead of using pull requests. Pull requests are private, and publicly uploaded patches allow everyone that doesn't happen to get a pull request to participate in the testing of the patch.

    http://rails.lighthouseapp.com/p...

    July 30th, 2008 @ 01:15 AM

  2. Hampton Catlin
    Hampton Catlin

    It won't let me upload a patch. Keeps failing.

    On Tue, Jul 29, 2008 at 8:15 PM, Lighthouse wrote:

    July 30th, 2008 @ 01:30 AM

  3. Pratik
    Pratik
    • State changed from open to wontfix

    I think we need a discussion on this on mailing list before we deprecate it.

    Thanks.

    August 22nd, 2008 @ 02:46 AM