#724 Deprecating ActiveRecord::Base#attributes= - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#724 ✓wontfix

Deprecating ActiveRecord::Base#attributes=

Reported by Hampton Catlin | July 30th, 2008 @ 12:18 AM | in 2.x

This is an extremely ugly method that is not ruby like enough and its been around since the beginning.

We discussed this in #ruby-contrib and everyone agreed. So, I branched and fixed it.

The new method that merges in attributes is ActiveRecord::Base#merge_attributes instead of ActiveRecord::Base#attributes= which is misleading because it looks like assignment.

I have added a deprecation warning to the use of ActiveRecord::Base#attributes=

There is a pull request on GitHub for this patch.

Comments and changes to this ticket

Rick July 30th, 2008 @ 01:15 AM
- State changed from “new” to “open”
Hey, we upload patches to Lighthouse instead of using pull requests. Pull requests are private, and publicly uploaded patches allow everyone that doesn't happen to get a pull request to participate in the testing of the patch.
http://rails.lighthouseapp.com/p...
You flagged this item as spam.
Hampton Catlin July 30th, 2008 @ 01:30 AM
It won't let me upload a patch. Keeps failing.
On Tue, Jul 29, 2008 at 8:15 PM, Lighthouse wrote:
Pratik August 22nd, 2008 @ 02:46 AM
- State changed from “open” to “wontfix”
I think we need a discussion on this on mailing list before we deprecate it.

Thanks.