Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• 

  Paweł Kondzior July 30th, 2008 @ 01:26 PM

  • no changes were found...

  • 001_allow_option_merger_merging_lambdas_version_2.diff 1.5 KB

• You flagged this item as spam.
  

  Piotr Usewicz July 31st, 2008 @ 10:18 AM

  +1

• You flagged this item as spam.
  

  hosiawak July 31st, 2008 @ 10:20 AM

  +1

• You flagged this item as spam.
  

  Paweł Kondzior August 1st, 2008 @ 11:17 AM

  • Assigned user set to “josh”

• You flagged this item as spam.
  

  Paweł Kondzior August 4th, 2008 @ 08:53 AM

  • Assigned user cleared.

• You flagged this item as spam.
  

  Paweł Kondzior August 4th, 2008 @ 09:48 AM

  maybe first example doesn't show what benefits we have from this patch.

  class Article
    belongs_to :author
    has_many :comments
  
    with_options(:include => [:author, :comments], :order => 'created_at DESC') do |base|
      base.named_scope :order_by, lambda { |order| { :order => order } }
      base.nameD_scope :created_by, lambda { |author| { :conditions => ['created_by = ?', author.id } }
    end
  end
  

  It is much Dry to use with_otpions and just type Article.order_by("authors.name DESC") than doin Article.base.order_by("authors.name DESC")

• You flagged this item as spam.
  

  Jacek Becela November 15th, 2008 @ 12:52 PM

  After I started using named_scopes, all my models contain a few or often more than a dozen named_scopes with lambdas and I could really use such a feature.

  This is better than chaining some common named_scope with every other scope, like say: Article.with_author_and_comments.order_by(something).

  On the other hand, there is another problem that this patch would not solve, and I'd love it had:

  Say you have a deleted_at column which is a common pattern for having "undo" in your app, etc.

  I'd like to have a DEFAULT named_scope so Article.all and Article.order_by(something) would always add SQL fragment "deleted_at is null". A default named_scope.

  Implementation would of course go into named_scope and not into OptionMerger.

• You flagged this item as spam.
  

  Paweł Kondzior November 15th, 2008 @ 03:41 PM

  Jacek: look at this ticket: http://dev.rubyonrails.org/ticke... and http://github.com/rubaidh/defaul...

  I think too that it would be very cool to have default_scope inside AR.

• 

  DHH November 15th, 2008 @ 03:49 PM

  • State changed from “new” to “committed”