#842 ActiveRecord::Reflection cannot be compared with nil - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#842 ✓resolved

ActiveRecord::Reflection cannot be compared with nil

Reported by Bob Aman | August 15th, 2008 @ 08:51 PM | in 2.x

ActiveRecord::Reflection instances currently throw an exception if compared with nil. I added a simple nil check to the == method.

You flagged this item as spam.
Ryan Bates August 15th, 2008 @ 09:53 PM
It's probably best to fix this for other objects as well.
```
reflection == Object.new # raises an error
```
Attached is a patch which ensures the object is a reflection before comparing.
- no_error_when_comparing_reflection_with_other_object.diff 1.9 KB
You flagged this item as spam.
Bob Aman August 15th, 2008 @ 10:26 PM
Good point, agreed.
Pratik August 16th, 2008 @ 08:21 PM
- Title changed from “PATCH: ActiveRecord::Reflection cannot be compared with nil” to “ActiveRecord::Reflection cannot be compared with nil”
Repository August 16th, 2008 @ 08:39 PM
- State changed from “new” to “resolved”
(from [8f4d3957a6986fe450cfd9058bb92ae1d6e5e745]) Don't raise exception when comparing ActiveRecord::Reflection. [#842 state:resolved]

Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...