This project is archived and is in readonly mode.

#895 ✓committed
Adam Milligan

has_one :through errors

Reported by Adam Milligan | August 25th, 2008 @ 12:47 AM | in 2.x

This patch resolves two small errors in has_one :through associations:

1) An unassigned has_one :through association should return nil when referenced. Instead, it returns an empty array. This is due to the call to #reset_target! on AssociationCollection, which is the most derived class that defines that method in the inheritance hierarchy for HasOneThroughAssociation.

2) Assigning to a has_one :through association does not correctly assign to the target of the association. This is due to the way the target gets set in the attribute writer method. The attribute writer creates the join association, then delegates to the attribute reader, with an explicit reload, to recreate the has_one :through association and save it on the instance. However, after calling the attribute reader, the attribute writer overwrites the instance variable with an out of date association object.

This patch includes tests for each of these behaviors, along with fixes.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

Referenced by