Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Fixed Return-Path in ActionMailer

#914

When the mail header 'return-path' was set, sending mail resulted in this Exception:

Net::SMTPSyntaxError: 501 <email@example.com>: missing or malformed local part

This patch strips the additional < and > from return-path if it's set as the sender address.

Reported by Mutwin Kraus · August 27th, 2008 @ 12:01 PM

State: duplicate
Milestone: 2.x
Assigned to: Michael Klishin (antares) Michael Klishin (antares)
Importance: none

Activity

  1. Jonathan S. Katz
    Jonathan S. Katz

    Unfortunately, that fix broke when I tried running it on my fork on Rails due to the class-type of the return-path header used by TMail. I propose a slightly different fix - please see attached.

    October 6th, 2008 @ 07:07 AM

  2. Pratik
    Pratik
    • State changed from new to incomplete
    • Assigned user set to Pratik

    Patch is missing tests.

    Thanks.

    January 18th, 2009 @ 05:58 AM

  3. Jonathan S. Katz
    Jonathan S. Katz

    The test is relatively straightforward, I just never had a chance to write it. Unfortunately, due to the amount of time this took and my need to avoid custom-Rails patches, I've switched to using MailFactory and a lightweight mailer that I wrote to handle my present email needs.

    If you would like, I can still write up some tests.

    Thanks,

    Jonathan

    February 4th, 2009 @ 07:45 PM

  4. Pratik
    Pratik
    • Assigned user changed from Pratik to Michael Klishin (antares)

    Yes please.

    Assigning to Michael as he has more experience with the Mailer stuff.

    Thanks.

    February 4th, 2009 @ 07:55 PM

  5. Frederick Cheung
    Frederick Cheung
    • State changed from incomplete to duplicate

    February 6th, 2009 @ 01:00 AM