Bah, wasn't expecting markdown.

ActiveSupport::JSON cannot parse a string as a hash value that end with backslashes if there are subsequent values in the hash, ie:

string = "{\"bad\":\"\\\\\",\"trailing\":\"\"}"
puts string
#=> {"bad":"\\","trailing":""}
p ActiveSupport::JSON.decode(string)
#=> ActiveSupport::JSON::ParseError: Invalid JSON string

The json gem parser works correctly:

require 'json'
p JSON.parse(string)
#=>{"bad"=>"\\", "trailing"=>""}

There is no problem if the backslash is not the last character, or if there is no subsequent values in the hash:

string = "{\"good\":\"\\\\x\",\"trailing\":\"\"}"
puts string
#=> {"good":"\\x","trailing":""}
p ActiveSupport::JSON.decode(string)
#=> {"good"=>"\\x", "trailing"=>""}

string = "{\"good\":\"\\\\\"}"
puts string
#=> {"good":"\\"}
p ActiveSupport::JSON.decode(string)
#=> {"good"=>"\\"}

with this patch it seems that \ becomes .

\ -> \ (1 stays as 1) \ -> \ (2 becomes 1) \\ -> \ (3 becomes 2) \\ -> \ (4 becomes 2)

my bad. please ignore the above comment. the patch is fine.

I don't have an edge environment around

It's literally a three line change (including tests) - Can't you just read the patch and replay?

Verified problem that described above.

I've attached a patch. That is fixed patch by Daniel Sheppard.

verified

+1 Both patches apply cleanly to the respective branches. All tests pass.

(from [b3381cacaf7735ec6eb108e378ba255ebf6ffb14]) Fix that JSON parser fails to read escaped backslashes.

[#973 state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/b3381cacaf7735ec6eb108e378ba25...

louis vuitton watches