Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Elad Meidar's latest activity

Sunday, August 09 2009
2254 When specifying url, form should be generated with it, but not this.href was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 5:52 PM

    +1 verified, +1 on patch, applies cleanly to 2-3-stable and master, all tests pass. manually tested on a mini test application.

1715 AR:Base mangles dates when user submits only part of the fields was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 5:40 PM

    +1 Verified, +1 patch. applies on 2-3-stable and master with all tests pass

3022 [PATCH] ActiveSupport tests fail when run from a directory with a space in it... was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 5:27 PM

    +1 verified and applies on master, fails on 2-3-stable.

3012 test tasks fail when db/schema.rb doesn't exist was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 5:22 PM

    +1 on idea and message, verified and applies cleanly on 2-3-stable and master

    sidenote: there should be a test suit for the basic included rake tasks, there are...

2653 validates_uniqueness_of unicode aware field length was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 5:18 PM

    -1 Patch applies on master but fails test, i was unable to trace the generated SQL in the tests log to see what is really going on. Since mb_chars[x,x] is obvio...

2329 Default to :all if :select contains comma when counting was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:32 PM

    +1 on idea, -1 on patch, does not apply "Patch does not have a valid e-mail address."

1331 Allow arbitrary named_scope instances to be merged was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:20 PM

    @james, Not clear what you are after.

    You can chain named_scopes for a while now, but you want AND on the return record set ?

2443 2.3.2 marshalling problem - Browser shows error 500 was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:07 PM

    I think that's expected, obviously one of the values in your hash resolves to a large string, simply because it's a large object, can you check what is in your ...

3020 ActiveResource#exists? does not work at all was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:01 PM

    +1 makes sense, both patches apply here and tests pass with the patches.

1543 index "unique_schema_migrations" should use table prefix/suffix was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 3:45 PM

    +1 Patch applies cleanly on 2-3-stable as tests pass too.

    Is it really necessary for 2 applications to create the same index ? i think it's something the develo...