This project is archived and is in readonly mode.
When specifying url, form should be generated with it, but not this.href
In helpers/url_helper.rb was the following code:
when confirm && method
"if (#{confirm_javascript_function(confirm)}) { #{method_javascript_function(method)} };return false;"
when method
"#{method_javascript_function(method, url, href)}return false;"
It means, that when I pass :href to link_to helper, my url was not used.
I've provided patch with test.
-
Max LapshinHey, what's the problem? There is bug, which is illustrated in test and a fix.
-
Henrik Nyh- Tag changed from 2.3-rc2, link_to, url_helper to 2.3-rc2, link_to, patch, url_helper
-
CancelProfileIsBroken
- Tag changed from 2.3-rc2, link_to, patch, url_helper to 2.3-rc2, link_to, url_helper
There's not necessarily a problem. Core team is doing some post-2.3.2 planning right now, so not many patches are being applied.
-
Max Lapshin
- Tag changed from 2.3-rc2, link_to, url_helper to 2.3.2, bug, link_to, patch, test, url_helper
Why not a problem? I've accepted patch, with test, which shows, that implementation violates documentation.
-
Max Lapshin
I've repeated this patch again 2.3.2, it is still actual
-
CancelProfileIsBroken
No one is saying it's a bad patch. You asked what the problem was. I tried to explain. Patches don't get instantly applied, that's all.
-
Max Lapshin
Ok, I see.
-
Max Lapshin
- Title changed from When specifying url, form should be generated with it, but not this.href to [PATCH] When specifying url, form should be generated with it, but not this.href
-
Pratik- Title changed from [PATCH] When specifying url, form should be generated with it, but not this.href to When specifying url, form should be generated with it, but not this.href
-
CancelProfileIsBroken
- Tag changed from 2.3.2, bug, link_to, patch, test, url_helper to 2.3.2, bug, bugmash, link_to, patch, test, url_helper
-
Rizwan Rezaverified
+1 This works in master and 2-3-stable. All tests pass. Also tested manually via a test app.
-
David Trasbo+1
Patch applies cleanly to edge. All tests are passing.
-
David Trasbo
verified
-
Elad Meidar+1 verified, +1 on patch, applies cleanly to 2-3-stable and master, all tests pass. manually tested on a mini test application.
-
Tristan Dunn- Tag changed from 2.3.2, bug, bugmash, link_to, patch, test, url_helper to 2.3.2, bug, bugmash, link_to, patch, test, url_helper, verified
+1
Verified patch applies to master and 2-3-stable cleanly with passing tests.
-
Repository
- State changed from new to resolved
(from [0af4b0755f507d41590b5315966c9a20949f79f9]) Make sure link_to generates the form with the specified :href if any [#2254 When specifying url, form should be generated with it, but not this.href state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/0af4b0755f507d41590b5315966c9a... -
Repository
(from [9e29c084eb0551eb18b666c8df53b9985af8aa16]) Make sure link_to generates the form with the specified :href if any [#2254 When specifying url, form should be generated with it, but not this.href state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/9e29c084eb0551eb18b666c8df53b9... -
CancelProfileIsBroken
- Assigned user cleared.
- Tag changed from 2.3.2, bug, bugmash, link_to, patch, test, url_helper, verified to 2.3.2, bug, link_to, patch, test, url_helper, verified
- Milestone cleared.