#2254 When specifying url, form should be generated with it, but not this.href - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2254 ✓resolved

When specifying url, form should be generated with it, but not this.href

Reported by Max Lapshin | March 16th, 2009 @ 03:23 PM

In helpers/url_helper.rb was the following code:


when confirm && method
     "if (#{confirm_javascript_function(confirm)}) { #{method_javascript_function(method)} };return false;"
when method
     "#{method_javascript_function(method, url, href)}return false;"

It means, that when I pass :href to link_to helper, my url was not used.

I've provided patch with test.

0001-When-specifying-url-form-should-be-generated-with-i.patch 2.5 KB

Comments and changes to this ticket

You flagged this item as spam.
Max Lapshin April 5th, 2009 @ 02:40 PM
Hey, what's the problem? There is bug, which is illustrated in test and a fix.
You flagged this item as spam.
Henrik Nyh April 5th, 2009 @ 03:29 PM
- Tag changed from “2.3-rc2, link_to, url_helper” to “2.3-rc2, link_to, patch, url_helper”
CancelProfileIsBroken April 5th, 2009 @ 03:29 PM
- Tag changed from “2.3-rc2, link_to, patch, url_helper” to “2.3-rc2, link_to, url_helper”
There's not necessarily a problem. Core team is doing some post-2.3.2 planning right now, so not many patches are being applied.
You flagged this item as spam.
Max Lapshin April 20th, 2009 @ 03:17 PM
- Tag changed from “2.3-rc2, link_to, url_helper” to “2.3.2, bug, link_to, patch, test, url_helper”
Why not a problem? I've accepted patch, with test, which shows, that implementation violates documentation.
You flagged this item as spam.
Max Lapshin April 20th, 2009 @ 03:23 PM
I've repeated this patch again 2.3.2, it is still actual
CancelProfileIsBroken April 20th, 2009 @ 03:33 PM
No one is saying it's a bad patch. You asked what the problem was. I tried to explain. Patches don't get instantly applied, that's all.
You flagged this item as spam.
Max Lapshin April 20th, 2009 @ 03:38 PM
Ok, I see.
You flagged this item as spam.
Max Lapshin April 20th, 2009 @ 03:48 PM
- Title changed from “When specifying url, form should be generated with it, but not this.href” to “[PATCH] When specifying url, form should be generated with it, but not this.href”
Pratik April 20th, 2009 @ 03:52 PM
- Title changed from “[PATCH] When specifying url, form should be generated with it, but not this.href” to “When specifying url, form should be generated with it, but not this.href”
CancelProfileIsBroken August 6th, 2009 @ 01:51 PM
- Tag changed from “2.3.2, bug, link_to, patch, test, url_helper” to “2.3.2, bug, bugmash, link_to, patch, test, url_helper”
Rizwan Reza August 8th, 2009 @ 01:34 PM
verified

+1 This works in master and 2-3-stable. All tests pass. Also tested manually via a test app.
David Trasbo August 8th, 2009 @ 04:30 PM
+1

Patch applies cleanly to edge. All tests are passing.
David Trasbo August 9th, 2009 @ 04:51 PM
verified
You flagged this item as spam.
Elad Meidar August 9th, 2009 @ 05:52 PM
+1 verified, +1 on patch, applies cleanly to 2-3-stable and master, all tests pass. manually tested on a mini test application.
You flagged this item as spam.
Tristan Dunn August 9th, 2009 @ 11:04 PM
- Tag changed from “2.3.2, bug, bugmash, link_to, patch, test, url_helper” to “2.3.2, bug, bugmash, link_to, patch, test, url_helper, verified”
+1

Verified patch applies to master and 2-3-stable cleanly with passing tests.
Repository August 10th, 2009 @ 01:01 AM
- State changed from “new” to “resolved”
(from [0af4b0755f507d41590b5315966c9a20949f79f9]) Make sure link_to generates the form with the specified :href if any [#2254 state:resolved]

Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/0af4b0755f507d41590b5315966c9a...
Repository August 10th, 2009 @ 01:01 AM
(from [9e29c084eb0551eb18b666c8df53b9985af8aa16]) Make sure link_to generates the form with the specified :href if any [#2254 state:resolved]

Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/9e29c084eb0551eb18b666c8df53b9...
CancelProfileIsBroken August 10th, 2009 @ 02:15 AM
- Assigned user cleared.
- Tag changed from “2.3.2, bug, bugmash, link_to, patch, test, url_helper, verified” to “2.3.2, bug, link_to, patch, test, url_helper, verified”
- Milestone cleared.