Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Xavier Noria

Xavier Noria

Member of 1 project: Ruby on Rails

Xavier Noria's latest activity

Monday, February 16 2009
1995 skip_relative_url_root is broken was updated in Ruby on Rails
  • Xavier Noria
    • Assigned user cleared.
    by Xavier Noria at 10:20 PM

    I got the name of two tests reversed, patch updated.
  • Xavier Noria
    Xavier Noria created the ticket at 10:03 PM

    The current implementation of skip_relative_url_root is broken:

    • if :only_path is true this option is ignored

    • if :only_path is false the relative_url_root is...
Sunday, February 01 2009
922 has_many through transaction rollback was updated in Ruby on Rails
Wednesday, January 21 2009
1785 Empty file uploads should not come through as empty Tempfiles was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 12:33 AM

    Exactly, my untested guess is that to test if the file was uploaded you just check value[:filename].blank?.

    If that's correct checking the size would not be nec...
Tuesday, January 20 2009
1785 Empty file uploads should not come through as empty Tempfiles was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 6:45 PM

    I think it doesn't matter if you cannot come up with a use case if you can be correct by the same price.

    The patch should test whether a file was uploaded, and ...
  • Xavier Noria
    Xavier Noria commented at 5:53 PM

    An uploaded file could have size 0... Wouldn't be possible to test something else like value[:filename].nil? ?

    Not really into it so don't know if it is a valid...
Sunday, January 18 2009
1765 AR::Base#all(:order => '') => invalid SQL was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 9:12 PM

    I am -1 here. The API shouldn't be designed to eat everything. In particular I don't really see the documentation stating that you can pass blank?s to :order (i...
Saturday, January 17 2009
1774 refactor #try to use inheritance was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 11:03 AM

    Good rdoc trick!
  • Xavier Noria
    Xavier Noria commented at 1:58 AM

    Hi Josh, just a few details about the rdoc:

    • Section headers have no colon normally. I've seen a few exceptions in the current tree whose remaining time of exi...
Friday, January 02 2009
1675 Pluralized AR models (think Posts.find(:all) instead of Post.find(:all)) was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 2:19 AM

    Mixed feelings as well.

    Also, I often write Posts.all. That kind of suggests there's something into this feature. But on the other hand models are singular by c...