Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Leigh Caplan

Leigh Caplan

Web Development Engineer · Not a member

Leigh Caplan's latest activity

Friday, July 23 2010
4942 ActiveSupport::TimeZone.[] incorrectly stores bogus values in zones_map was updated in Ruby on Rails
  • Leigh Caplan
    Leigh Caplan commented at 9:35 PM

    @plind yes, sorry I didn't see this for a month. This resolves the issue.
Thursday, July 22 2010
5177 ActiveSupport::Deprecation::DeprecationProxy objects wrap nil and false was updated in Ruby on Rails
  • Leigh Caplan
    Leigh Caplan commented at 1:57 AM

    Okay, here's the backported fix for 2.3.x
  • Leigh Caplan
    Leigh Caplan created the ticket at 1:30 AM

    ActiveSupport::Deprecation::DeprecationProxy objects aren't used much in Rails, but where they are, nothing is done to ensure that they don't wrap false or nil....
Tuesday, June 29 2010
4942 ActiveSupport::TimeZone.[] incorrectly stores bogus values in zones_map was updated in Ruby on Rails
  • Leigh Caplan
    • Assigned user changed from José Valim to Santiago Pastorino
    by Leigh Caplan at 1:54 AM
  • Leigh Caplan
    Leigh Caplan commented at 1:53 AM

    Here's a patch with both the lookup fix and a test. I couldn't think of any way other than mocking out the call to find_tzinfo seeing as object apparently doesn...
Monday, June 28 2010
4942 ActiveSupport::TimeZone.[] incorrectly stores bogus values in zones_map was updated in Ruby on Rails
  • Leigh Caplan
    Leigh Caplan commented at 11:52 PM

    Hey guys,

    The 2.3 backport patch causes some additional unexpected behavior. It will never use the stored value in zones_map, and create a new TimeZone object e...
Wednesday, June 23 2010
4942 ActiveSupport::TimeZone.[] incorrectly stores bogus values in zones_map was updated in Ruby on Rails
  • Leigh Caplan
    Leigh Caplan commented at 6:36 PM

    I've included a test that passes in master... I just stubbed out the lookup method to return nil, to ensure that we're not explicitly relying on the TZInfo to d...
  • Leigh Caplan
    Leigh Caplan created the ticket at 3:39 AM 
    >> ActiveSupport::TimeZone['bogus']
=> nil
>> ActiveSupport::TimeZone.zones_map.key?('bogus')
=> true

    This really bites you if the value ends up being stored,...