Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Mislav's latest activity

Monday, July 19 2010
5147 The ":all" Domain Option For The Cookie Session Store Doesn't Allow Non-Stand... was updated in Ruby on Rails
  • Mislav
    Mislav commented at 10:35 PM

    Since when is this broken? I have some apps on Rails 3 in development using ".local" and I didn't notice session problems. I have cookie-based sessions, all def...

Saturday, July 17 2010
5138 [PATCH] Fix generated html for remote_function so that ampersands can be used... was updated in Ruby on Rails
  • Mislav
    Mislav commented at 12:58 PM

    Tests are definitely in order. The fact that there were no tests previously is probably what lead to this breakage.

Saturday, July 10 2010
5073 AR::Relation can't be encoded to JSON was updated in Ruby on Rails
  • Mislav
    Mislav commented at 5:11 PM

    What's wrong with pushing changes to my remote? With hub, the above link can be cherry-picked by just doing this:

    $ git cherry-pick http://github.com/mislav/ra...
Thursday, July 08 2010
5073 AR::Relation can't be encoded to JSON was created in Ruby on Rails
  • Mislav
    Mislav created the ticket at 9:26 PM

    Although AR::Relation provides to_json, it still can't be encoded with ActiveSupport::JSON.encode because the latter detects a circular reference and errors out...

5069 ActiveRecord `destroy_all` returns empty array instead of destroyed records was updated in Ruby on Rails
  • Mislav
    Mislav commented at 4:22 PM

    Heads-up to those who might have already pulled: I've just force-pushed something I forgot to my branch for master.

  • Mislav
    Mislav commented at 3:48 PM

    That wasn't a behavior of Rails 2.3. Why change it? A user can iterate over the "destroyed" objects collection and check which records are truly destroyed? and ...

  • Mislav
    Mislav created the ticket at 1:19 PM

    Just noticed a regression in Rails 3: destroy_all always returns an empty array. I've added tests to master and 2-3-stable that destroy_all should return destro...

Sunday, June 27 2010
4411 rails.js on body.observe('submit',...) but submit doesn't bubble in IE was updated in Ruby on Rails
  • Mislav
    • Assigned user set to josh
    by Mislav at 10:17 PM

    Just to indicate, work on this is being done in the "prototype-ujs" repo and I expect Josh Peek will merge this in core when he's satisfied with the script. It ...

Wednesday, June 09 2010
4411 rails.js on body.observe('submit',...) but submit doesn't bubble in IE was updated in Ruby on Rails
  • Mislav
    Mislav commented at 12:56 AM

    Trent: simply loading that file after Prototype should work, yeah. The caveat is, it only changes the behavior of Element#on, not observe. This will work:

    docu...
Wednesday, May 26 2010
2189 count breaks has_many through association collection with named scope was updated in Ruby on Rails
  • Mislav
    Mislav commented at 11:01 AM

    I would only close if there was a passing test committed to both 2-3-stable and master.