James MacAulay's profile

James MacAulay commented at 4:19 PM
James MacAulay created the ticket at 4:15 PM

The problem comes from ticket #3164, which ended up as commit 6361d42.

Its concern was with AR::B#clone, but it had the side effect of giving dup almost exact...

James MacAulay commented at 8:38 PM
- Title changed from rendering a partial with an array as its :object behaves as if it were :collection to [PATCH] rendering a partial with an array as its :object should not behave as if it were passed as :collection
- Tag changed from action_view to action_view, bug
by James MacAulay at 8:28 PM
Made a patch to fix this. At first I thought this was an intentional change, but after working with the code more I realize that it's probably just a bug.
James MacAulay created the ticket at 7:42 PM
This code does not work the same way as it did in 2.x:
```
render :partial => "things", :object => ['foo', 'bar', 'baz']
```
In 2.x, the "things" partial would be ren...

- Title changed from [BUG] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original to [BUG] [PATCH] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original
by James MacAulay at 8:35 PM
Tested and fixed.
- Tag changed from bug patch to bug, patch
by James MacAulay at 8:33 PM
James MacAulay created the ticket at 8:30 PM
This is the current implementation of AS::MB::Chars#+ :
```
  def +(other)
    self << other
  end
```
But + concatenation should not alter the original like << does.

James MacAulay created the ticket at 6:51 PM

Currently there is no way to specify a custom root key for JSON encoding of ActiveModel/ActiveRecord objects.

This patch allows a :root option in calls to encod...