Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[BUG] [PATCH] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original

#4646

This is the current implementation of AS::MB::Chars#+ :

  def +(other)
    self << other
  end

But + concatenation should not alter the original like << does.

Reported by James MacAulay · May 18th, 2010 @ 08:30 PM

State: resolved
Milestone: 3.0.2
Assigned to: José Valim José Valim
Importance: Medium

Activity

  1. James MacAulay
    James MacAulay
    • Tag changed from bug patch to bug, patch

    May 18th, 2010 @ 08:33 PM

  2. James MacAulay
    James MacAulay
    • Title changed from [BUG] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original to [BUG] [PATCH] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original

    Tested and fixed.

    May 18th, 2010 @ 08:35 PM

  3. Yaroslav Markin
    Yaroslav Markin
    • Tag changed from bug, patch to activesupport, bug, multibyte, patch
    • Assigned user set to Manfred Stienstra

    Seems like a good one to me, +1

    May 18th, 2010 @ 10:34 PM

  4. Norman Clarke
    Norman Clarke

    +1 Nice catch. This should definitely be applied.

    May 19th, 2010 @ 02:39 PM

  5. Rizwan Reza
    Rizwan Reza
    • No changes were found…

    May 21st, 2010 @ 12:45 AM

  6. Manfred Stienstra
    Manfred Stienstra
    • Assigned user changed from Manfred Stienstra to Michael Koziarski

    Looks ok to me

    May 21st, 2010 @ 07:20 AM

  7. Norman Clarke
    Norman Clarke
    • Tag changed from activesupport, bug, multibyte, patch to activesupport, bug, multibyte, patch, verified
    • Importance changed from to Medium

    Looks like this one doesn't apply any more. Here's an updated patch which applies against the current Rails master.

    June 30th, 2010 @ 01:30 AM

  8. Santiago Pastorino
    Santiago Pastorino
    • Assigned user changed from Michael Koziarski to José Valim
    • State changed from new to open
    • Milestone cleared.

    June 30th, 2010 @ 02:14 AM

  9. Repository
    Repository
    • State changed from open to resolved

    June 30th, 2010 @ 12:23 PM

  10. Jeremy Kemper