#4646 [BUG] [PATCH] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4646 ✓resolved

[BUG] [PATCH] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original

Reported by James MacAulay | May 18th, 2010 @ 08:30 PM | in 3.0.2

This is the current implementation of AS::MB::Chars#+ :

  def +(other)
    self << other
  end

But + concatenation should not alter the original like << does.

Comments and changes to this ticket

You flagged this item as spam.
James MacAulay May 18th, 2010 @ 08:33 PM
- Tag changed from “bug patch” to “bug, patch”
You flagged this item as spam.
James MacAulay May 18th, 2010 @ 08:35 PM
- Title changed from “[BUG] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original” to “[BUG] [PATCH] ActiveSupport::Multibyte::Chars concatenation with #+ (plus) method should not alter the original”
Tested and fixed.
- mb_chars_concatenation_fix.diff 1.9 KB
You flagged this item as spam.
Yaroslav Markin May 18th, 2010 @ 10:34 PM
- Tag changed from “bug, patch” to “activesupport, bug, multibyte, patch”
- Assigned user set to “Manfred Stienstra”
Seems like a good one to me, +1
You flagged this item as spam.
Norman Clarke May 19th, 2010 @ 02:39 PM
+1 Nice catch. This should definitely be applied.
Rizwan Reza May 21st, 2010 @ 12:45 AM
- no changes were found...
Manfred Stienstra May 21st, 2010 @ 07:20 AM
- Assigned user changed from “Manfred Stienstra” to “Michael Koziarski”
Looks ok to me
You flagged this item as spam.
Norman Clarke June 30th, 2010 @ 01:30 AM
- Tag changed from “activesupport, bug, multibyte, patch” to “activesupport, bug, multibyte, patch, verified”
- Importance changed from “” to “Medium”
Looks like this one doesn't apply any more. Here's an updated patch which applies against the current Rails master.
- 0001-fix-as-mb-chars-to-not-alter-self-4646-state-resolve.patch 1.9 KB
Santiago Pastorino June 30th, 2010 @ 02:14 AM
- Assigned user changed from “Michael Koziarski” to “José Valim”
- State changed from “new” to “open”
- Milestone cleared.
Repository June 30th, 2010 @ 12:23 PM
- State changed from “open” to “resolved”
(from [16cef77d37ffe3e2cdc6f7db76b4ae59ce4cbc5b]) Fix AS::MB::Chars#+ to not alter self [#4646 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/16cef77d37ffe3e2cdc6f7db76b4ae...
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
[bulk edit]