Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Andrew Kaspick's latest activity

Wednesday, September 29 2010
5356 [PATCH] rails.js fix for submitting forms with multiple submit buttons was updated in Ruby on Rails
  • Andrew Kaspick
    Andrew Kaspick commented at 8:00 PM

    So everything committed to prototype-ujs will be merged for the next rails point release? I just thought it would have been merged for the final rails 3 release...

Tuesday, September 28 2010
5356 [PATCH] rails.js fix for submitting forms with multiple submit buttons was updated in Ruby on Rails
Friday, September 24 2010
5695 Properly memoize protected methods was updated in Ruby on Rails
  • Andrew Kaspick
    Andrew Kaspick commented at 5:09 AM

    Adding a patch for the 2.3 branch as well.

Thursday, September 23 2010
5695 Properly memoize protected methods was updated in Ruby on Rails
  • Andrew Kaspick
    Andrew Kaspick commented at 10:56 PM

    This patch needs to be backported to rails 2.3.x as the issue exists there as well. Do I need to provide an additional patch for that branch as well?

  • Andrew Kaspick
    Andrew Kaspick created the ticket at 10:55 PM
    class Test
      extend ActiveSupport::Memoizable
    
    protected
      def test
      end
      memoize :test
    end
    

    Before this patch, the test method would be accessible as a publ...

Monday, August 16 2010
5356 [PATCH] rails.js fix for submitting forms with multiple submit buttons was updated in Ruby on Rails
  • Andrew Kaspick
    Andrew Kaspick commented at 9:02 AM

    Fair enough. I just wanted to make sure that's what the plan for the submit button was. Besides that, Larry's patch is what mine would be then too.

Sunday, August 15 2010
5356 [PATCH] rails.js fix for submitting forms with multiple submit buttons was updated in Ruby on Rails
  • Andrew Kaspick
    Andrew Kaspick commented at 6:18 AM

    I'm away traveling so am a bit staged with getting online. I noticed Larry attached a new patch. I have a new patch as well, but don't do the "|| false" part as...

Saturday, August 14 2010
5356 [PATCH] rails.js fix for submitting forms with multiple submit buttons was updated in Ruby on Rails
  • Andrew Kaspick
    Andrew Kaspick commented at 7:38 PM

    Storing on the form makes much more sense. I'll get another patch together soon. Thanks.

  • Andrew Kaspick
    Andrew Kaspick commented at 1:12 PM

    Thanks Larry. It appeared to be working for me locally, but looking at the code for serializeElements in prototype, it does seem to do a comparison with the 'na...