This project is archived and is in readonly mode.
Properly memoize protected methods
#5695
class Test
extend ActiveSupport::Memoizable
protected
def test
end
memoize :test
end
Before this patch, the test method would be accessible as a public method. This patch properly makes the memoized method protected.
-
Andrew KaspickThis patch needs to be backported to rails 2.3.x as the issue exists there as well. Do I need to provide an additional patch for that branch as well?
-
Andrew Kaspick
Adding a patch for the 2.3 branch as well.
-
Santiago Pastorino
- State changed from new to open
- Milestone set to 2.3.10
- Assigned user set to Michael Koziarski
- Importance changed from to Low
Pushed.
master: http://github.com/rails/rails/commit/fb08e334d61b1706db754733b20907...
3-0-stable: http://github.com/rails/rails/commit/0387d5b6f29a46884f2250caa8d826...Pending the push for 2-3-stable
-
Michael Koziarski- State changed from open to resolved