#5695 Properly memoize protected methods - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5695 ✓resolved

Properly memoize protected methods

Reported by Andrew Kaspick | September 23rd, 2010 @ 10:55 PM | in 2.3.10

class Test
  extend ActiveSupport::Memoizable

protected
  def test
  end
  memoize :test
end

Before this patch, the test method would be accessible as a public method. This patch properly makes the memoized method protected.

You flagged this item as spam.
Andrew Kaspick September 23rd, 2010 @ 10:56 PM
This patch needs to be backported to rails 2.3.x as the issue exists there as well. Do I need to provide an additional patch for that branch as well?
You flagged this item as spam.
Andrew Kaspick September 24th, 2010 @ 05:09 AM
Adding a patch for the 2.3 branch as well.
- protected_method_memoized_2_3_branch.diff 2.2 KB
Santiago Pastorino September 25th, 2010 @ 12:34 AM
- State changed from “new” to “open”
- Milestone set to “2.3.10”
- Assigned user set to “Michael Koziarski”
- Importance changed from “” to “Low”
Pushed.
master: http://github.com/rails/rails/commit/fb08e334d61b1706db754733b20907...
3-0-stable: http://github.com/rails/rails/commit/0387d5b6f29a46884f2250caa8d826...

Pending the push for 2-3-stable
Michael Koziarski September 26th, 2010 @ 11:52 PM
- State changed from “open” to “resolved”

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>