Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Matt Duncan

Matt Duncan

Not a member

Matt Duncan's latest activity

Saturday, August 08 2009
2660 InstanceTag to_label_tag id attribute was updated in Ruby on Rails
  • Matt Duncan
    • Tag changed from actionpack, actionview, form_helper, instance_tag, label, to_label_tag to actionpack, actionview, bugmash, form_helper, instance_tag, label, to_label_tag
    by Matt Duncan at 4:52 PM

    Patch didn't apply cleanly for me so I re-created it and tweaked the tests for better coverage.

    I've attached a patch.
1051 select_datetime: Documentation or Implementation Bug was updated in Ruby on Rails
  • Matt Duncan
    • Assigned user changed from Pratik to José Valim
    • Tag changed from actionpack, bugmash, datehelper, helper to actionpack, bug, bugmash, datehelper, helper
    by Matt Duncan at 3:53 PM

    Fixing Rizwan's user/tag changes that got overwritten with my comment.
  • Matt Duncan
    • Assigned user changed from José Valim to Pratik
    • Tag changed from actionpack, bug, bugmash, datehelper, helper to actionpack, bugmash, datehelper, helper
    by Matt Duncan at 3:50 PM

    Not Reproducible.

    The following tests in actionpack/test/template/date_helper_test.rb (2-3-stable and master) all use the :datetime_separator option:

    • test_sele...
2937 id for radio_button behavior was updated in Ruby on Rails
2944 Titleize doesn't take all-uppercase words into account was updated in Ruby on Rails
  • Matt Duncan
    Matt Duncan commented at 2:27 PM

    @stevestmartin great comments. I'd vote to leave titleize alone for now also. This is something which would be a lot easier to solve on an individual applicatio...
2431 deprecate fails on methods ending with equal sign was updated in Ruby on Rails
  • Matt Duncan
    Matt Duncan commented at 4:50 AM

    +1 for both patches (2-3-stable and master), verified that both are passing tests and working as expected.
1229 Add :from scoping respect to Calculations module was updated in Ruby on Rails
  • Matt Duncan
    Matt Duncan commented at 3:58 AM

    +1 Although I don't see a lot of use-cases for this I think it's good to be consistent. I've added a test, if anyone has thoughts on how this could be better te...
2630 Adding a validates_with method was updated in Ruby on Rails
  • Matt Duncan
    Matt Duncan commented at 3:05 AM

    +1

    Pluggable validations and validation plugins would be really nice.

    Passes all tests on 2-3-stable.
2607 Sent_on should default to now was updated in Ruby on Rails
  • Matt Duncan
    Matt Duncan commented at 2:44 AM

    +1 I updated the patch to apply cleanly to the latest 2-3-stable, looks good and all tests pass.

    I've attached a patch.
755 Dirty Tracking (partial updates) don't see decimal column updates was updated in Ruby on Rails
  • Matt Duncan
    Matt Duncan commented at 2:21 AM

    Not Reproducible.

    Fixed the original test based on Tom's findings and no failures are reported.

    I've attached a patch.