Mike Enriquez's profile - rails

Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Mike Enriquez's latest activity

Monday, September 28 2009

2536 .:format feature breaks URL compliance (rfc1738) - should be optional was updated in Ruby on Rails

Mike Enriquez commented at 8:23 AM

+1 It would be nice for this to work by default without configuration.

The .:format feature should be configurable by setting a list of formats. I don't see any...

Sunday, September 27 2009

3192 should be able to truncate a multibyte string to a max # of bytes was updated in Ruby on Rails

Mike Enriquez commented at 10:03 PM

-1 I don't think this fits into the responsibility for Chars. Since we don't have a "String".limit_characters we don't need a "String".mb_chars.limit_bytes.

I h...

2114 ActiveSupport lacks beginning_of_hour was updated in Ruby on Rails

Mike Enriquez commented at 9:06 PM
+1 verified both patches. It may be worth discussing if we need beginning_of_minute and beginning_of_second.

3226 [PATCH] form_for for new objects with :index set was updated in Ruby on Rails

Mike Enriquez commented at 8:26 PM
-1 The same result can be accomplished by doing
```
form_for(@post, :html => { :id => "new_post_6" })
```
The patch provides a cleaner syntax, but I don't think it is...

3278 [PATCH] Allow PKG_NAME env variable to control the directory name used when ... was updated in Ruby on Rails

- Tag changed from 2-3-stable, bugmash, feature, patch, rake, rake_dev to 2-3-stable, bugmash-review, feature, patch, rake, rake_dev
by Mike Enriquez at 8:09 PM
Mike Enriquez commented at 8:07 PM
+1 verified. Applies to 2-3-stable and master. Setting a combination of RAILS_PKG_DESTINATION and PKG_NAME with the destination in .gitignore makes a lot of sen...

3094 [PATCH] Ignorable codes(call super twice) in MemCacheStore was updated in Ruby on Rails

Mike Enriquez commented at 7:49 PM
-1 This changes the API for MemCacheStore. It changes the return value as well as removing the mutex instance variable. These things may be in there by design.

3245 rewrite_asset_path should respect already existing query strings was updated in Ruby on Rails

Mike Enriquez commented at 7:02 PM
1. I agree with John. I can't think of a use for a dynamic asset that would need a query string. More info would be helpful.

Sunday, May 10 2009

2439 [PATCH] ActionController::Integration::Session no longer mangles multiparamet... was updated in Ruby on Rails

- Assigned user cleared.
by Mike Enriquez at 1:57 AM
I think there's something funky with the patch. You probably meant this
```
k = first ? key.to_s : "[#{key.to_s}]"
```
instead of
```
k = first ? key.to_s : "[key.t...
```