#3094 [PATCH] Ignorable codes(call super twice) in MemCacheStore - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3094 ✓stale

[PATCH] Ignorable codes(call super twice) in MemCacheStore

Reported by Yoshimasa Niwa | August 25th, 2009 @ 11:02 AM

MemCacheStore, the session store class for memcached backend has weird, ignorable codes inside its initialize.

def initialize(app, options = {})
  # snip...
  super
  # snip...
  @mutex = Mutex.new # unused?

  super # called again?
end

double super call might be harmful because AbstractStore which is base class of MemCacheStore manipulates option argument in its call.
It must not be harmful though, really weird.

I attached a patch to remove this code, just removing. Even after applying this patch, all test we can pass.

mem_cache_store.rb.patch 545 Bytes

Comments and changes to this ticket

CancelProfileIsBroken September 25th, 2009 @ 12:43 PM
- Tag set to “bugmash”
You flagged this item as spam.
Blue Box Chris September 26th, 2009 @ 11:51 PM
patch applied but you are missing the header so git complains about missing email address.
You flagged this item as spam.
Yoshimasa Niwa September 27th, 2009 @ 04:14 AM
ah, sorry. attach new patch with headers for git-am.
- 0001-Remove-ignorable-codes-in-MemCacheStore.patch 927 Bytes
You flagged this item as spam.
John Pignata September 27th, 2009 @ 04:20 AM
-1 Doesn't apply to master - applies to 2-3-stable but doesn't have a demonstrable impact besides a little clean-up on a maintenance branch.
You flagged this item as spam.
Blue Box Jesse September 27th, 2009 @ 06:54 PM
BugMash: +1 verified

Patch applies on 2-3-stable. Makes sense to clean this up.

Doesn't apply on Master based on a redesign of the session data.
You flagged this item as spam.
Mike Enriquez September 27th, 2009 @ 07:49 PM
-1 This changes the API for MemCacheStore. It changes the return value as well as removing the mutex instance variable. These things may be in there by design.
Rizwan Reza February 12th, 2010 @ 12:46 PM
- Tag cleared.
[bulk edit]
Santiago Pastorino February 2nd, 2011 @ 04:44 PM
- State changed from “new” to “open”
- Importance changed from “” to “”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:44 PM
- State changed from “open” to “stale”