This project is archived and is in readonly mode.
[PATCH] Ignorable codes(call super twice) in MemCacheStore
MemCacheStore, the session store class for
memcached backend has weird, ignorable codes inside its
initialize.
def initialize(app, options = {})
# snip...
super
# snip...
@mutex = Mutex.new # unused?
super # called again?
end
double super call might be harmful because
AbstractStore which is base class of
MemCacheStore manipulates option argument
in its call.
It must not be harmful though, really weird.
I attached a patch to remove this code, just removing. Even after applying this patch, all test we can pass.
-
mem_cache_store.rb.patch
545 Bytes
-
CancelProfileIsBroken- Tag set to bugmash
-
Blue Box Chris
patch applied but you are missing the header so git complains about missing email address.
-
Yoshimasa Niwa
ah, sorry. attach new patch with headers for git-am.
-
John Pignata
-1 Doesn't apply to master - applies to 2-3-stable but doesn't have a demonstrable impact besides a little clean-up on a maintenance branch.
-
Blue Box JesseBugMash: +1 verified
Patch applies on 2-3-stable. Makes sense to clean this up.
Doesn't apply on Master based on a redesign of the session data.
-
Mike Enriquez-1 This changes the API for MemCacheStore. It changes the return value as well as removing the mutex instance variable. These things may be in there by design.
-
-
Santiago Pastorino
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale