This project is archived and is in readonly mode.

#3094 ✓stale
Yoshimasa Niwa

[PATCH] Ignorable codes(call super twice) in MemCacheStore

Reported by Yoshimasa Niwa | August 25th, 2009 @ 11:02 AM

MemCacheStore, the session store class for memcached backend has weird, ignorable codes inside its initialize.

def initialize(app, options = {})
  # snip...
  # snip...
  @mutex = # unused?

  super # called again?

double super call might be harmful because AbstractStore which is base class of MemCacheStore manipulates option argument in its call.
It must not be harmful though, really weird.

I attached a patch to remove this code, just removing. Even after applying this patch, all test we can pass.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket