Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

JasonKing's latest activity

Saturday, May 16 2009
2162 layout chaining was updated in Ruby on Rails
  • JasonKing
    JasonKing commented at 11:23 PM

    Have you guys seen my second comment in this ticket?

    Where multiple layout statements with conditions will have their conditions combined, but the template itse...

Sunday, April 05 2009
2419 [Patch] Raise specific exceptions for violated database constraints was updated in Ruby on Rails
  • JasonKing
    JasonKing commented at 12:31 PM

    From earlier - I think you're right and that it's cleaner to leave my suggestion out of your patch. Propagating the original exception is the best solution. Let...

  • JasonKing
    JasonKing commented at 1:53 AM

    Looks good.

    I had been working on something like this a little while back in some spare cycles - the one thing I really found useful was to pull out the column ...

Tuesday, March 24 2009
1651 Sqlite, sqlite3 bug in add_column when column is primary key (Trac #9385) was updated in Ruby on Rails
  • JasonKing
    • Assigned user cleared.
    by JasonKing at 12:46 AM

    Your original comment said that you were using 2.3 :) I guess you're using 2.2 - so yeah, this bug was fixed in the 2.3 final release (v2.3.2).

    Before this, in ...

Monday, March 23 2009
1651 Sqlite, sqlite3 bug in add_column when column is primary key (Trac #9385) was updated in Ruby on Rails
  • JasonKing
    • Tag changed from 2.2.2, database, migrations, refactoring, sql, sqlite3 to 2.2.2, database, migrations, primary_key, refactoring, sql, sqlite3
    by JasonKing at 9:42 PM

    Which version of rails are you using? In 2.3.2 the adapter doesn't even use the ALTER TABLE statement for adding primary key columns - so you're not using the f...

Saturday, March 14 2009
2235 savepoints in sqlite3 was created in Ruby on Rails
  • JasonKing
    JasonKing created the ticket at 1:10 PM

    Savepoints are supported in >= 3.6.8 sqlite - but are not implemented in the adapter.

    I had them patched into #2080 but other tests seemed to be triggering the ...

2080 sqlite missing ddl transactions and savepoints was updated in Ruby on Rails
  • JasonKing
    JasonKing commented at 12:35 PM

    Pulled out the savepoint stuff and rebased (and squashed some whitespace I pulled in when I pasted the tests from #1651).

Friday, March 13 2009
1651 Sqlite, sqlite3 bug in add_column when column is primary key (Trac #9385) was updated in Ruby on Rails
  • JasonKing
    JasonKing commented at 11:47 AM

    I suspect that Pratik meant to put the ticket #2080 in his comment. I've included the fix for this in my patch for a related issue - just took your tests direct...

2080 sqlite missing ddl transactions and savepoints was updated in Ruby on Rails
  • JasonKing
    JasonKing commented at 11:44 AM

    Done, fixed #1651 as well.

  • JasonKing
    JasonKing commented at 12:34 AM

    Thanks. I'll have some time later today (about 8 hours from now) and will take a look and add these tests then.