Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Andrew Bloomgarden's latest activity

Thursday, June 10 2010
4806 Regexp ignore-case option in routes breaks params was updated in Ruby on Rails
  • Andrew Bloomgarden
    Andrew Bloomgarden commented at 2:30 AM

    And that makes the ActionDispatch test pass, as expected.

  • Andrew Bloomgarden
    Andrew Bloomgarden commented at 2:13 AM

    One last patchfile, this one with an explicit test added for RegexpWithNamedGroups.

  • Andrew Bloomgarden
    • Tag changed from rails3 routes, bug, rack-mount, rails3, regression to rails3 routes, bug, patch, rack-mount, rails3, regression
    by Andrew Bloomgarden at 12:19 AM

    And here's a fix. RegexpWithNamedGroups was treating (?i-mx:blah) and the like as captures.

Wednesday, June 09 2010
4806 Regexp ignore-case option in routes breaks params was updated in Ruby on Rails
  • Andrew Bloomgarden
    • Tag changed from rails3 routes, bug, rails3, regression to rails3 routes, bug, rack-mount, rails3, regression
    by Andrew Bloomgarden at 11:50 PM

    Turns out this is a rack-mount issue, so I've attached a failing test case for that.

  • Andrew Bloomgarden
    Andrew Bloomgarden commented at 11:36 PM

    Alright, I believe I've found the issue. Given this in the routing test:

    controller :articles do
      scope '/articles', :name_prefix => 'article' do
        scope :p...
  • Andrew Bloomgarden
    Andrew Bloomgarden commented at 11:20 PM

    Attached is a patch with a couple of failing tests.

  • Andrew Bloomgarden
    • Title changed from Two regexp options in routing breaks params to Regexp ignore-case option in routes breaks params
    by Andrew Bloomgarden at 9:42 AM
  • Andrew Bloomgarden
    Andrew Bloomgarden created the ticket at 9:07 AM

    (see attached for an example app with this code)

    If you have a blank app with the following controller:

    class TestController < ApplicationController
      def inde...
Thursday, June 03 2010
4751 ActiveRecord::Base.compute_type swallows NoMethodError was updated in Ruby on Rails
  • Andrew Bloomgarden
    Andrew Bloomgarden commented at 1:37 AM

    I've updated the patch to include tests on compute_type's standard behavior.

Wednesday, June 02 2010
4751 ActiveRecord::Base.compute_type swallows NoMethodError was updated in Ruby on Rails
  • Andrew Bloomgarden
    • Tag changed from bug, rails3, regression to bug, patch, rails3, regression
    by Andrew Bloomgarden at 6:59 AM

    Here's the patch and a (now-passing) test.