#4806 Regexp ignore-case option in routes breaks params - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4806 ✓committed

Regexp ignore-case option in routes breaks params

Reported by Andrew Bloomgarden | June 9th, 2010 @ 09:07 AM | in 3.0.2

(see attached for an example app with this code)

If you have a blank app with the following controller:

class TestController < ApplicationController
  def index
    render :text => params.inspect
  end
end

and the following in routes.rb:

get "/:foo/:bar" => 'test#index', :foo => /first/i, :bar => /second/

when going to /first/second, the expected response would have both the :foo and :bar components in it, but it actually is the following:

{"action"=>"index", "foo"=>"first", "controller"=>"test"}

The second component somehow gets swallowed. I'm not sure exactly what's going on, so hopefully we can figure this out.

routing_problem.tgz 77.9 KB

Comments and changes to this ticket

You flagged this item as spam.
Andrew Bloomgarden June 9th, 2010 @ 09:42 AM
- Title changed from “Two regexp options in routing breaks params” to “Regexp ignore-case option in routes breaks params”
DHH June 9th, 2010 @ 05:11 PM
- Milestone cleared.
- Assigned user set to “josh”
You flagged this item as spam.
Andrew Bloomgarden June 9th, 2010 @ 11:20 PM
Attached is a patch with a couple of failing tests.
- ignore_case_routing_problem.diff 1.4 KB
You flagged this item as spam.
Andrew Bloomgarden June 9th, 2010 @ 11:36 PM
Alright, I believe I've found the issue. Given this in the routing test:
```
controller :articles do
  scope '/articles', :name_prefix => 'article' do
    scope :path => '/:title', :title => /[a-z]+/i, :as => :with_title do
      match '/:id', :to => :with_id
    end
  end
end
```
the Rack::Mount::Route for article_with_title has named_captures
```
{:path_info=>{:title=>0, :id=>2}}
```
but without the ignore-case flag it has
```
{:path_info=>{:title=>0, :id=>1}}
```
Now to actually fix it…
You flagged this item as spam.
Andrew Bloomgarden June 9th, 2010 @ 11:50 PM
- Tag changed from “rails3 routes, bug, rails3, regression” to “rails3 routes, bug, rack-mount, rails3, regression”
Turns out this is a rack-mount issue, so I've attached a failing test case for that.
- ignore_case_problem_tests.diff 1.9 KB
You flagged this item as spam.
Andrew Bloomgarden June 10th, 2010 @ 12:19 AM
- Tag changed from “rails3 routes, bug, rack-mount, rails3, regression” to “rails3 routes, bug, patch, rack-mount, rails3, regression”
And here's a fix. RegexpWithNamedGroups was treating (?i-mx:blah) and the like as captures.
- ignore_case_problem_fix.diff 2.5 KB
You flagged this item as spam.
Andrew Bloomgarden June 10th, 2010 @ 02:13 AM
One last patchfile, this one with an explicit test added for RegexpWithNamedGroups.
- ignore_case_problem_fix2.diff 3.3 KB
You flagged this item as spam.
Andrew Bloomgarden June 10th, 2010 @ 02:30 AM
And that makes the ActionDispatch test pass, as expected.
José Valim June 23rd, 2010 @ 12:23 PM
- State changed from “new” to “committed”
Closing since it was already applied to Rack-Mount.
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
[bulk edit]