David Trasbo
Ruby on Rails developer · Member of 1 project: Ruby on Rails
David Trasbo's latest activity
Thursday, September 23 2010
-
- State changed from incomplete to resolved
Fixed in Rails 3. If someone needs this fix in Rails 2, please do push for that the patch gets applied.
-
- State changed from open to resolved
Fixed in http://github.com/rails/rails/commit/92cb0b8be658eb7e569d0a30c4ef78... - awesome.
Wednesday, September 22 2010
-
David Trasbo commented at 3:04 PMMarjon,
+1 for the fix, but -1 for the tests. I think you should make a separate test for percentage signs, to make sure people know they're there for a reason.
Tuesday, September 21 2010
-
David Trasbo commented at 4:51 PMHans and Ryan,
Perhaps I could have been more clear. :)
What's missing is to format the patch using
format-patchto include commit message, author, etc. -
- State changed from new to open
- Importance changed from to Low
Hans,
Could you please attach a patch according to the guidelines outlined here?
https://rails.lighthouseapp.com/projects/8994/sending-patches
Thanks! :)
-
- State changed from new to wontfix
- Assigned user cleared.
- Importance changed from to Low
I agree completely with José Valim: "This behavior should not be added form_tag. form_tag is a basic/raw constructor."
-
David Trasbo commented at 6:10 AMYou're right, Steve! Was able to duplicate this issue on master:
Warmup:
Started GET "/people" for 127.0.0.1 at 2010-09-21 07:07:24 +0200 Processing by Peopl...
Monday, September 20 2010
-
- State changed from resolved to open
Steve,
Ah, ok. No problem. Reopening this and putting it on my follow-up list. Will most likely have a look at this again tomorrow.
-
- State changed from new to invalid
Marking as invalid for now. Will reopen if Matt shares some more detail on how to reproduce.
-
- State changed from new to invalid
Using the option syntax works on master.