Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

David Trasbo's latest activity

Thursday, September 23 2010
59 When loading a plugin via rubygems, rake tasks aren't included was updated in Ruby on Rails
  • David Trasbo
    • State changed from incomplete to resolved
    by David Trasbo at 7:50 AM

    Fixed in Rails 3. If someone needs this fix in Rails 2, please do push for that the patch gets applied.

5667 Ruby 1.9: Strings no longer respond to #each was updated in Ruby on Rails
Wednesday, September 22 2010
5570 Fragment cache logging fails in 3.0 when fragment path contains printf chars,... was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 3:04 PM

    Marjon,

    +1 for the fix, but -1 for the tests. I think you should make a separate test for percentage signs, to make sure people know they're there for a reason.

Tuesday, September 21 2010
5555 actionmailer 2.3.9 should now require 'uri' was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 4:51 PM

    Hans and Ryan,

    Perhaps I could have been more clear. :)

    What's missing is to format the patch using format-patch to include commit message, author, etc.

  • David Trasbo
    • State changed from new to open
    • Importance changed from to Low
    by David Trasbo at 6:32 AM

    Hans,

    Could you please attach a patch according to the guidelines outlined here?

    https://rails.lighthouseapp.com/projects/8994/sending-patches

    Thanks! :)

5670 [PATCH] file_field_tag makes the enclosing form multipart (see b17b980). was updated in Ruby on Rails
  • David Trasbo
    • State changed from new to wontfix
    • Assigned user cleared.
    • Importance changed from to Low
    by David Trasbo at 1:52 PM

    I agree completely with José Valim: "This behavior should not be added form_tag. form_tag is a basic/raw constructor."

5570 Fragment cache logging fails in 3.0 when fragment path contains printf chars,... was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 6:10 AM

    You're right, Steve! Was able to duplicate this issue on master:

    Warmup:

    Started GET "/people" for 127.0.0.1 at 2010-09-21 07:07:24 +0200
      Processing by Peopl...
Monday, September 20 2010
5570 Fragment cache logging fails in 3.0 when fragment path contains printf chars,... was updated in Ruby on Rails
  • David Trasbo
    • State changed from resolved to open
    by David Trasbo at 8:44 PM

    Steve,

    Ah, ok. No problem. Reopening this and putting it on my follow-up list. Will most likely have a look at this again tomorrow.

5463 AssetTagHelper.cache_asset_timestamps Issue was updated in Ruby on Rails
  • David Trasbo
    • State changed from new to invalid
    by David Trasbo at 8:20 PM

    Marking as invalid for now. Will reopen if Matt shares some more detail on how to reproduce.

3937 g.fixture_replacement ignored was updated in Ruby on Rails
  • David Trasbo
    • State changed from new to invalid
    by David Trasbo at 7:48 PM

    Using the option syntax works on master.