Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Eloy Duran

Eloy Duran

Developer · Member of 1 project: Ruby on Rails

Eloy Duran's latest activity

Wednesday, February 04 2009
1863 check_box doesn't work with nested forms was updated in Ruby on Rails
1861 Nested attribute accessors should ignore new records with truthy _delete key was updated in Ruby on Rails
  • Eloy Duran
    Eloy Duran commented at 8:27 AM

    I have added some documentation and fixed a few whitespace errors. I'm a whitespace fanatic :)

    +1 The patch indeed tests the expected behaviour.
Tuesday, February 03 2009
1861 Nested attribute accessors should ignore new records with truthy _delete key was updated in Ruby on Rails
  • Eloy Duran
    Eloy Duran commented at 5:58 PM

    Arg, don't mind the formatting you get the point :)
  • Eloy Duran
    Eloy Duran commented at 5:55 PM

    I would suggest to change the test test_should_remove_delete_key_from_arguments_hash_of_new_records to use '0' for the 'delete' key. Right now the record is rej...
1849 fields_for with nested attributes association should accept explicitly passed... was updated in Ruby on Rails
  • Eloy Duran
    Eloy Duran commented at 9:50 AM

    @Michael: Well ActiveRecord and DataMapper and any objecty which responds to new_record?. (The same kind of stuff happens on line 261 btw.)

    It's not a deal brea...
  • Eloy Duran
    Eloy Duran commented at 12:00 AM

    +1 Applies clean, tests run and looks good to me.
Sunday, February 01 2009
1728 Accessor methods for association instances. was updated in Ruby on Rails
  • Eloy Duran
    Eloy Duran commented at 1:09 PM

    This was applied in commit ec8f04584479aff895b0b511a7ba1e9d33f84067. Please close the ticket.
1732 Remove transaction queries from assert_queries count. was updated in Ruby on Rails
  • Eloy Duran
    Eloy Duran commented at 12:22 PM

    Moved the removal of the transaction queries to helper.rb and added test for not counting SHOW FIELDS FROM.
Saturday, January 31 2009
1202 Add attributes writer method for an association. was updated in Ruby on Rails
  • Eloy Duran
    Eloy Duran commented at 6:04 PM

    And the new patch.
  • Eloy Duran
    Eloy Duran commented at 6:03 PM

    Created a new patch because apparently for some reason my format-patch skills fail… This is just 1 patch with all patches combined in one. Here's the commit mes...