Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Rohit Arondekar

Rohit Arondekar

Member of 1 project: Ruby on Rails

Rohit Arondekar's latest activity

Monday, June 14 2010
4847 [PATCH] Remove unused String#html_safe! was updated in Ruby on Rails
  • Rohit Arondekar
    Rohit Arondekar commented at 3:09 PM

    For the record I still agree with Cody though, if the method can't be called it shouldn't exist.
  • Rohit Arondekar
    Rohit Arondekar commented at 2:56 PM

    If the method is to be kept I would prefer it if the message is more self explanatory. This will avoid confusion and people filing bug reports.

    If anybody agree...
  • Rohit Arondekar
    • Assigned user set to José Valim
    by Rohit Arondekar at 8:00 AM

    Interesting.

    I found the reason why html_safe! doesn't actually do anything besides raising an exception:

    For performance reasons safe strings are implemented ...
4824 ActiveSupport::JSON.decode seems to remove newlines and multiple spaces was updated in Ruby on Rails
  • Rohit Arondekar
    Rohit Arondekar commented at 4:01 AM

    I think my comparison examples are wrong. In Ruby 1.8.7, \u000a are not recognized as unicode chars.

    ruby-1.8.7-p174 > "\u000a"
 => "u000a"

    Whereas in Ruby 1....
Sunday, June 13 2010
4811 count before where fails was updated in Ruby on Rails
4824 ActiveSupport::JSON.decode seems to remove newlines and multiple spaces was updated in Ruby on Rails
  • Rohit Arondekar
    • Assigned user set to José Valim
    by Rohit Arondekar at 10:44 AM

    Note: That JSON string gives an error. I've included the corrected string in the samples below.

    Confirmed on Rails master and 1.9.2-head.
    Does not happen on 1.8...
4777 render(:inline) in a layout before yield replaces original content was updated in Ruby on Rails
  • Rohit Arondekar
    Rohit Arondekar commented at 4:55 AM

    Applies cleanly and the tests pass on 1.8.7 and 1.9.2-head.
4825 Some text helper methods inappropriately calling "sanitize" was updated in Ruby on Rails
Saturday, June 12 2010
4844 Rename sanitize to escape in test names of certain text helpers was created in Ruby on Rails
4777 render(:inline) in a layout before yield replaces original content was updated in Ruby on Rails
  • Rohit Arondekar
    Rohit Arondekar commented at 2:20 AM

    +1 applies cleanly, tests pass on the following Rubies:

    • ruby 1.8.7 (2009-06-12 patchlevel 174)
    • ruby 1.9.2dev (2010-06-06 revision 28184)