Activity (RSS)

In several places in the association preload code, foreign keys are converted to integers (to_i). For example, in the `preload_has_many_association` method, ...

http://github.com/rails/rails/co...

Added an assert_no_match to the generator test with explanation as Mislav suggested.

+1

I would only change the test so it tests that "default_url_options" isn't present in generated mailer. Little explicitness, prevents contributors to make s...

This patch removes the use of default_url_options from generated mailers and improves the documentation about URL generation with ActionMailer.

See #20 for mo...

We don't own GitHub.

http://github.com/feeds/rails/co... feed has max 10 elements. This is not enough to watch project. Please make it bigger, e.g. 100.

Please take a look at #32. I created a patch which updates the documentation and removes the default_url_options call from the generator.

Well, I generally agree. We only have to update docs for ActionMailer and we can remove `default_url_options` from generator.

Great changes overall. However, I did notice one small potential issue. I don't think the default_url_options[:host] call should be placed in the mailer. This ...

I think I finally tracked it down. It's the inspect method of AssociationProxy that does a reload if the target isn't loaded yet and therefore wipes the collec...

Quoting the column name fixes it as expected

D'oh, should have quoted that column name

This causes failures on mysql. I believe because key is a reserved word?

The test_add_index in migration_test.rb fails on sqlite2 when attempting to add a unique index on a column. The value of that column is null for all rows, whic...

Attached a new patch where flash sweeping is done after assign_shortcuts, so that @_session can be checked. The previous patch had a problem accessing the sess...

If you need to explicitly set the date order when using the date and time field helpers, then it is likely you will need to do it everywhere in your app.

This...

Applied in http://github.com/rails/rails/co...

Applied at http://github.com/rails/rails/co...

use :as